Do not set VCAP_APPLICATION env var during kpack staging #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VCAP_* vars are not set during diego staging. Restore this behaviour regarding VCAP_APPLICATION for kpack staging. At the moment, the contents of VCAP_APPLICATION are set to the output of Hash#to_s, which is not valid JSON anyway. Co-authored-by: Kieron Browne <[email protected]>
|
LGTM, thanks for the PR! Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that during kpack staging, VCAP_APPLICATION is set to a Hash#to_s string. It should be a json string, although in diego staging, VCAP_APPLICATION is not set at all.
This PR excludes VCAP_APPLICATION from the environment in the same way that VCAP_SERVICES is already excluded.
When deploying postfacto, for example, the rails-assets precompilation triggers
bundle exec rails assets:precompilewhich ends up trying to deserialise VCAP_APPLICATION from json. This fails as it gets the ruby hash string. In CF on VMs, VCAP_APPLICATION is not set and the staging succeeds.Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests