Log incomplete requests when stopping CC #2256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
When CC receives the signal to stop execution, it simply aborts outstanding requests. With this change, all incomplete requests will be written into the log file when (after) the Thin server is stopped.
The request logging code has been restructured similar to
Metrics::RequestMetrics
.An explanation of the use cases your change solves
This change enables operators to identify requests that have not been completed due to a restart of Cloud Controller. Without this change it was required to search through the logs and compare the
Started ...
andCompleted ...
messages in order to identify which requests were still processed when CC stopped. This helps analyzing potentially blocking and/or slow requests that need to be improved.Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests