Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

Separate extensions into their own repos #25

Closed
wyuenho opened this issue Jan 24, 2013 · 17 comments
Closed

Separate extensions into their own repos #25

wyuenho opened this issue Jan 24, 2013 · 17 comments
Milestone

Comments

@wyuenho
Copy link
Contributor

wyuenho commented Jan 24, 2013

No description provided.

@mallim
Copy link
Contributor

mallim commented Jun 23, 2013

I can help out on this. But you have to create the repo first 😄

@wyuenho
Copy link
Contributor Author

wyuenho commented Jun 23, 2013

https://github.com/wyuenho/backgrid-filter
https://github.com/wyuenho/backgrid-select-all
https://github.com/wyuenho/backgrid-paginator
https://github.com/wyuenho/backgrid-text-cell
https://github.com/wyuenho/backgrid-select2-cell

I've already moved the moment-cell extension. You can use that as a guide on how to move to the extensions.

I've added you as a collaborator of the new repos.

Thanks so much!

@mallim
Copy link
Contributor

mallim commented Jun 24, 2013

I will do it at night 😄 May I use bower to point to the correct backgrid version to pull from?

@wyuenho
Copy link
Contributor Author

wyuenho commented Jun 24, 2013

Let's hold off on working on bower for the moment. The requirement is to support CommonJS because it's a requirement for Travis-CI, other than that I see very little utility for support bower or component or whatever at the moment.

@mallim
Copy link
Contributor

mallim commented Jun 24, 2013

Actually just need to do configure the bower.json (for the extensions) then perform
npm install bower

If not, any pointers how do you plan to configure the extensions to point to the backgrid?

For bower, just need to configure the backgrid as the dependencies to pull in.

@wyuenho
Copy link
Contributor Author

wyuenho commented Jun 24, 2013

By directly copying backgrid.js over for now. Once all the extension have been extracted, we can then make backgrid available on npm, and all the extensions will reference it as a dependency.

@mallim
Copy link
Contributor

mallim commented Jun 27, 2013

@wyuenho please review on the migration, how will you want to make backgrid available on npm and all the extensions to reference from it. I will suggest the other external components can also be reference in a similar way?

@wyuenho
Copy link
Contributor Author

wyuenho commented Jun 28, 2013

Ideally there would be a asset management system that consumes bower or component to linearize the dependency order of the JS and CSS files during concatenation. Does such a tool exist at the moment that's not AMD? Maybe Ender? If yes that let's find out what's required to support that.

@wyuenho
Copy link
Contributor Author

wyuenho commented Jun 28, 2013

I'm currently looking at Ender and browserify. They both look pretty good and all we have to do is support CommonJS. I'm still looking for a package manager that can package up CSS as well as JS.

@mallim
Copy link
Contributor

mallim commented Jun 28, 2013

I am using requirejs to achieve this 😄 but I guess you are not into it ...

@wyuenho
Copy link
Contributor Author

wyuenho commented Jun 28, 2013

It's a passing fad that gives you 50 different options to export 1 symbol at a time. It will soon be obsoleted by ES6. :D

@kriswill
Copy link

+1 CommonJS

@wyuenho
Copy link
Contributor Author

wyuenho commented Jun 30, 2013

@mallim I've grafted backgrid's old history back onto the extension repos and did a force push. Please clone again and see if there's any problem.

I'm closing this ticket for now.

Thanks @mallim a lot. You've been a big help. Where do I send a cake :D ?

@wyuenho wyuenho closed this as completed Jun 30, 2013
@mallim
Copy link
Contributor

mallim commented Jul 1, 2013

@wyuenho Just a few questions: Do we need to do anything to make the extensions commonjs compatible? What utility do you have in mind to improve the build? For example, the dependencies should be pulled in for the various extensions.

@wyuenho
Copy link
Contributor Author

wyuenho commented Jul 1, 2013

I've already UMDify the extensions. I'm still looking at options for building frontend components. They all look bad so far. The least bad solution seems to be Component, but its list of packages are very out of date.

@mallim
Copy link
Contributor

mallim commented Jul 1, 2013

Something similar to cartero (https://github.com/rotundasoftware/cartero) will be good

@wyuenho
Copy link
Contributor Author

wyuenho commented Jul 1, 2013

Ok, the conclusion is more than 9 months later, package managers for SPA still suck balls. Let's just continue using package.json to get Travis-CI working now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants