fix: allow requireing alias modules

[vicb]

What this PR solves / how to test

Fixes #6896

Author has addressed the following

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because:
• Changeset (Changeset guidelines)
  • TODO (before merge)
  • Changeset included
  • Changeset not necessary because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 030bfe0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253830172/npm-package-wrangler-6932

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6932/npm-package-wrangler-6932

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253830172/npm-package-wrangler-6932 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253830172/npm-package-create-cloudflare-6932 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253830172/npm-package-cloudflare-kv-asset-handler-6932

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253830172/npm-package-miniflare-6932

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253830172/npm-package-cloudflare-pages-shared-6932

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253830172/npm-package-cloudflare-vitest-pool-workers-6932

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253830172/npm-package-cloudflare-workers-editor-shared-6932

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253830172/npm-package-cloudflare-workers-shared-6932

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240925.1
workerd	1.20240925.0	1.20240925.0
workerd --version	1.20240925.0	2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[petebacondarwin]

A couple of queries...

[vicb]

/cc @pi0

[pi0]

It is a nice approach. I would suggest:

1. See if we can directly make unenv npm compat exports more compatible. it is likely we can do this and avoid the overhead and risks of interop at esbuild level
2. If we need interop, i would suggest to use something like this it is much safer. cjs interops can be really tricky.

[vicb]

Thanks for super valuable feedback @pi0!

I was hoping that given the restricted scope of this (/unenv/runtime/{npm,mock}) a simpler solution would be enough.

• If we need interop, i would suggest to use something like this it is much safer. cjs interops can be really tricky.

But if you think this is not safe, using interopDefault should solve all the problems if I understand correctly?

• See if we can directly make unenv npm compat exports more compatible. it is likely we can do this and avoid the overhead and risks of interop at esbuild level

One "issue" is that the unenv update in wrangler is paused for now because of a different issue. To make the change in unenv, we would need to update unenv and have a release without the perf_hook latest change. Might take longer than just releasing the change here (that we can revert later if no more needed).

[pi0]

Feel free to open a PR in unenv to revert that. (i think a simply uncomment in preset would solve it)

[petebacondarwin]

Let's merge this for now and iterate on the concerns that @pi0 raised.

[vicb]

Let's merge this for now and iterate on the concerns that @pi0 raised.

I marked the convos as resolved (not sure if it was actually required for that repo).
But we should take them into account to iterate.

Also one thing I tried is that use the .cjs instead of of the .mjs as a simpler fix.

However const f = require('cross-fetch') would not have the named exports (i.e. f.Headers === undefined)