🐛 BUG: ERROR SystemError [ERR_TTY_INIT_FAILED] While installing using Git Bash

[Muhammad-Sarfaraz]

Which Cloudflare product(s) does this pertain to?

C3 (npm create cloudflare), Wrangler

What version(s) of the tool(s) are you using?

2.27.3[C3]

What version of Node are you using?

v18.18.1

What operating system and version are you using?

Windows 10

Describe the Bug

Description

While installing the latest Cloudflare setup using the following command in Git Bash:

npm create cloudflare@latest

I encountered the following error:

ERROR  SystemError [ERR_TTY_INIT_FAILED]: TTY initialization failed: uv_tty_init returned EBADF (bad file descriptor)

Please provide a link to a minimal reproduction

No response

Please provide any relevant error logs

No response

[andyjessop]

@Muhammad-Sarfaraz I've tried to test this locally, but am unable to reproduce. I'm not on Windows, but we do have E2E tests for Windows for this workflow.

Can you just check again to see if this is still an issue for you?

[Muhammad-Sarfaraz]

@Muhammad-Sarfaraz I've tried to test this locally, but am unable to reproduce. I'm not on Windows, but we do have E2E tests for Windows for this workflow.

Can you just check again to see if this is still an issue for you?

Still facing issues with Git Bash on my OS, could a warning be added for this? Use Powershell instead git bash?

[andyjessop]

After some internal discussion, it looks like we do something similar, where instead of warning, we just move to raw mode instead:

workers-sdk/packages/wrangler/src/utils/onKeyPress.ts

Lines 22 to 25 in 3ee1353

	if (isInteractive()) {
	readline.emitKeypressEvents(stream);
	process.stdin.setRawMode(true);
	}

The advantage of this is that we could generalise it by creating a isTTYSupported() function.