feat: Added D1 Support #270

FlareLine · 2023-01-20T08:47:13Z

Summary

These changes add D1 support to the worker crate, resolving #221.

Due to the nature of local development with Rust workers, developing an easy process for locally debugging this integration may be somewhat difficult.

Attributions:

@KernelFreeze for initial contributions to the feature.
@SebastiaanYN for assistance with the query! macro.
@logankeenan for working on the integration tests.
@zebp for all the work they do on the crate, despite their massive existing workload.

FlareLine · 2023-01-26T23:43:38Z

After some messing about in both wrangler2 and workers-rs, I've finally gotten multiple parameters binding to a prepared statement. This should be the last change required for this implementation bar tests / bit of cleanup.

FlareLine · 2023-01-27T00:10:11Z

There's actually still a couple of things I need to add - I'll get these in hopefully in the next couple of days.

zebp

Looks really good, but we need to get some testing in worker-sandbox.

worker/src/env.rs

worker/src/lib.rs

worker/src/d1.rs

FlareLine · 2023-02-10T13:52:10Z

Apologies for the above, Github is funky...

FlareLine · 2023-02-26T06:30:50Z

Apologies for the delay, it's been a crazy couple of weeks. I'm currently writing some tests for this integration using the worker-sandbox crate. Hopefully this PR will be ready for review in the next couple of days. 🙏 cc @zebp

FlareLine · 2023-02-28T10:24:45Z

After attempting to write some tests for this integration. I have the pattern down pat. However, it seems like Miniflare doesn't like the types specified in worker... I'm not entirely sure how to solve this:

FlareLine · 2023-03-19T21:56:56Z

@FlareLine

I used this branch...

Hey @logankeenan,

Hmm interesting - I had hopefully gotten rid of any problems related to errors at this point. I will spend some time coming up with an interface that allows us to extract the cause of the error. Unfortunately (at the moment) Wrangler wraps the error cause up into the cause property of the thrown javascript Error rather than in the error message itself, and clearly my changes in error.rs aren't working to unwrap this as intended. I'll have a play around and see if I can work it out.

FlareLine · 2023-03-19T22:11:56Z

@logankeenan interestingly, I had to fix some issues with the macro after @zebp's changes to naming of the D1 interface. Macros are powerful, but can be quite fiddly when it comes to refactoring! I've pushed it up to CF to test and it seems to work okay, but I'm yet to test it locally. Would you mind giving this a go with the fixes and report back? :)

logankeenan · 2023-03-20T01:13:05Z

@FlareLine - My repo is now working as expected. However, I'm embarrassed to say it's because I'm now passing the --persist flag when running npx wrangler dev --local --persist 🤦. Your recent changes were still not working, so I re-read the documentation and realized my mistake. I'm sorry for the false positive!

logankeenan · 2023-03-31T12:16:02Z

@FlareLine

I've tested this branch quite a bit through a demo application. Is there anything I can help with on this PR?

FlareLine · 2023-04-04T07:37:09Z

@FlareLine

I've tested this branch quite a bit through a demo application. Is there anything I can help with on this PR?

Hey @logankeenan, I believe there were some conversations happening between @zebp and the D1 team regarding some questions. I'm not sure where those conversations are at. I'd be more than happy if you wanted to contribute some more tests to the PR - I've unfortunately come down with something so haven't had time to come back to this.

Apologies for the late reply.

logankeenan · 2023-04-04T13:52:24Z

@FlareLine

I'd be more than happy if you wanted to contribute some more tests to the PR - I've unfortunately come down with something so haven't had time to come back to this.

I can give the PR a look and see where more tests could be added. Take it easy and I hope you get better soon!

FlareLine · 2023-04-06T06:55:56Z

@FlareLine

I'd be more than happy if you wanted to contribute some more tests to the PR - I've unfortunately come down with something so haven't had time to come back to this.

I can give the PR a look and see where more tests could be added. Take it easy and I hope you get better soon!

Smephite · 2023-04-06T14:59:33Z

Why was this PR closed?

FlareLine · 2023-04-07T00:25:34Z

Why was this PR closed?

Uhh no idea, must have fumbled the bag and clicked close with comment - reopened, my apologies! 😅

alpancs · 2023-05-04T23:54:59Z

hi guys, thanks for creating this PR, but any updates on it? I think all the issues have been resolved.

logankeenan · 2023-05-05T01:04:49Z

I forked this branch and created a new PR since the original author is unavailable.

FlareLine · 2023-05-05T01:18:47Z

I forked this branch and created a new PR since the original author is unavailable.

Hey there! I've been attempting to see if I can get a hold of @zebp as there were some conversations he was having with the D1 team. I'm not entirely sure where those conversations are at. I think at the moment it's been fairly busy at Cloudflare, which is probably why it's been difficult to get time to take a look at getting this across the line.

logankeenan · 2023-05-05T01:21:32Z

@FlareLine

👋 Good to hear from you. Thanks for the update. Let me know how you'd like me to proceed. I'd be happy to close the PR I just opened. Whatever is easiest.

…support

FlareLine · 2023-05-05T01:44:47Z

@logankeenan I've just cherry-picked your integration test commit into this PR! Appreciate the work!

zebp · 2023-06-14T16:30:46Z

Closing in favor of #337

FlareLine and others added 2 commits January 20, 2023 19:42

Added initial contributions with some fixes

7616b40

Added multi-param binding functionality

8797385

FlareLine mentioned this pull request Jan 26, 2023

feat: added D1 integration #246

Closed

3 tasks

FlareLine marked this pull request as ready for review January 26, 2023 23:47

Explicitly call Error::from

c59505c

zebp requested changes Jan 27, 2023

View reviewed changes

worker/src/env.rs Outdated Show resolved Hide resolved

worker/src/lib.rs Outdated Show resolved Hide resolved

FlareLine added 2 commits January 28, 2023 11:14

Added feature flag

445a98c

Added README documentation

51a329e

FlareLine dismissed a stale review via 51a329e February 2, 2023 06:26

Update error handling

c725fcb

FlareLine dismissed a stale review via c725fcb February 2, 2023 06:58

SebastiaanYN reviewed Feb 6, 2023

View reviewed changes

worker/src/d1.rs Outdated Show resolved Hide resolved

Created query mcaro

419039b

FlareLine dismissed a stale review via 419039b February 10, 2023 13:41

FlareLine requested review from SebastiaanYN and zebp and removed request for SebastiaanYN and zebp February 10, 2023 13:51

Merge branch 'main' into d1-support

68e9cd0

FlareLine dismissed a stale review via 68e9cd0 February 14, 2023 10:41

Fixed broken macro + error cause handlin

3081e2c

FlareLine dismissed a stale review via 3081e2c March 19, 2023 22:10

FlareLine closed this Apr 6, 2023

FlareLine reopened this Apr 7, 2023

Merge branch 'main' into d1-support

c35d762

FlareLine dismissed a stale review via c35d762 April 7, 2023 00:26

logankeenan mentioned this pull request May 5, 2023

feat: Added D1 Support #314

Closed

logankeenan and others added 2 commits May 5, 2023 11:27

add integration test for d1

2154df8

Merge branch 'd1-support' of github.com:FlareLine/workers-rs into d1-…

f018e12

…support

FlareLine dismissed a stale review via f018e12 May 5, 2023 01:29

Merge branch 'main' into d1-support

b052e71

Keavon mentioned this pull request May 10, 2023

[Feature] D1 Support #221

Open

1 task

cometkim mentioned this pull request May 19, 2023

Consider using D1 instead of DO storage daangn/registry-edge#4

Open

zebp mentioned this pull request Jun 14, 2023

feat: add d1 support #337

Merged

zebp closed this Jun 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Added D1 Support #270

feat: Added D1 Support #270

FlareLine commented Jan 20, 2023 •

edited

Loading

FlareLine commented Jan 26, 2023

FlareLine commented Jan 27, 2023 •

edited

Loading

zebp left a comment

FlareLine commented Feb 10, 2023

FlareLine commented Feb 26, 2023

FlareLine commented Feb 28, 2023

FlareLine commented Mar 19, 2023 •

edited

Loading

FlareLine commented Mar 19, 2023

logankeenan commented Mar 20, 2023

logankeenan commented Mar 31, 2023

FlareLine commented Apr 4, 2023 •

edited

Loading

logankeenan commented Apr 4, 2023

FlareLine commented Apr 6, 2023

Smephite commented Apr 6, 2023

FlareLine commented Apr 7, 2023 •

edited

Loading

alpancs commented May 4, 2023

logankeenan commented May 5, 2023

FlareLine commented May 5, 2023

logankeenan commented May 5, 2023

FlareLine commented May 5, 2023

zebp commented Jun 14, 2023

feat: Added D1 Support #270

feat: Added D1 Support #270

Conversation

FlareLine commented Jan 20, 2023 • edited Loading

Summary

FlareLine commented Jan 26, 2023

FlareLine commented Jan 27, 2023 • edited Loading

zebp left a comment

Choose a reason for hiding this comment

FlareLine commented Feb 10, 2023

FlareLine commented Feb 26, 2023

FlareLine commented Feb 28, 2023

FlareLine commented Mar 19, 2023 • edited Loading

FlareLine commented Mar 19, 2023

logankeenan commented Mar 20, 2023

logankeenan commented Mar 31, 2023

FlareLine commented Apr 4, 2023 • edited Loading

logankeenan commented Apr 4, 2023

FlareLine commented Apr 6, 2023

Smephite commented Apr 6, 2023

FlareLine commented Apr 7, 2023 • edited Loading

alpancs commented May 4, 2023

logankeenan commented May 5, 2023

FlareLine commented May 5, 2023

logankeenan commented May 5, 2023

FlareLine commented May 5, 2023

zebp commented Jun 14, 2023

FlareLine commented Jan 20, 2023 •

edited

Loading

FlareLine commented Jan 27, 2023 •

edited

Loading

FlareLine commented Mar 19, 2023 •

edited

Loading

FlareLine commented Apr 4, 2023 •

edited

Loading

FlareLine commented Apr 7, 2023 •

edited

Loading