Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HelloRetryRequest #40

Open
Lekensteyn opened this issue Sep 21, 2017 · 1 comment
Open

Support HelloRetryRequest #40

Lekensteyn opened this issue Sep 21, 2017 · 1 comment

Comments

@Lekensteyn
Copy link
Contributor

Lekensteyn commented Sep 21, 2017

Currently the server just closes the connection when no supported groups are available. It should probably send a HRR in this case.

Similarly, the client (PR will be opened "soon") does not expect a HRR, it should retry the CH with appropriate changes (new keyshare for the group).

Important references:
https://tools.ietf.org/html/draft-ietf-tls-tls13-18#section-4.1.4 (Hello Retry Request)
https://tools.ietf.org/html/draft-ietf-tls-tls13-18#section-4.2.6.1 (PSK Binder)

Note: draft 22 changes the message significantly, requiring different parsing logic.

@kriskwiatkowski
Copy link
Contributor

Draft 24 adds


The value of selected_version in the HelloRetryRequest |  
-- | --
  |   |   | "supported_versions" extension MUST be retained in the ServerHello, |  
  |   |   | and a client MUST abort the handshake with an "illegal_parameter" |  
  |   |   | alert if the value changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants