Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal breaks popovers, dropdowns #22

Open
srph opened this issue Apr 22, 2017 · 1 comment
Open

Modal breaks popovers, dropdowns #22

srph opened this issue Apr 22, 2017 · 1 comment

Comments

@srph
Copy link

srph commented Apr 22, 2017

It appears that react-modal2 breaks dialogues (components that also use react-gateway) that require focus (e.g., inputs). This seems to be an effect of Modal.js#L10.

I'm not sure if I've seen this from other libraries, but it seems unnecessary. I also didn't find any tests for this 🤔 .

Anybody else having issues with this? 😓

@Azaeres
Copy link

Azaeres commented May 5, 2017

I'm having this problem as well. Rendering a react-modal2 appears to mess with the behavior of click handlers on the page. For example, I'd click an element that had a click handler attached, and instead of handling the click normally, it jumped the scroll position to the place the react-modal2 was located.

So I commented out the line on Modal.js#L10 per @srph's comment, and this problem went away. Haven't had time to figure out what the ideal fix for this would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants