[🐛 Bug]: Not all workers-compatible nodejs api is fully supported

[dario-piotrowicz]

Description

Not all nodejs API supported by the workers runtime (docs) is correctly supported, of the compatibility list:

• assert
• AsyncLocalStorage
• Buffer
• EventEmitter
• util

I think that we only support AsyncLocalStorage and Buffer but not the rest.

Support should be added since we already require the nodejs_compat flag to be specified so we should actually make sure that we support all the APIs provided by the flag.

---

Reproduction

For example see the api/hello route of this app: simple-pages-dir-13.4.2.

It generated an internal server error because of the use of node:events:

(Note that EventEmitters are workers-compatible as indicated above)

[dario-piotrowicz]

Related to: #244

---

@felix-schultz I'm pinging you in case you we'd be interested in following this 🙂, it does look like we can do things better in regards of node compatibility, I'll look into this soon 🙂👍

[dario-piotrowicz]

Note (to self)

currently we have this ugly hack that is needed because of a workers runtime bug:

next-on-pages/src/buildApplication/generateFunctionsMap.ts

Lines 47 to 53 in f72a56f

	// TODO: remove ASAP (after runtime fix) @dario
	await mkdir(nextOnPagesDistDir, { recursive: true });
	await writeFile(
	join(nextOnPagesDistDir, '..', 'node-buffer.js'),
	'export * from "node:buffer"'
	);
	///////////////////////////////////////////////

this would make the solution for nodejs modules require such hacks for all modules potentially making a bit of a mess, since I don't believe that there is a high demand for this fix (and the runtime bug should be fixed fairly soon) let's wait for the runtime to be fixed first (and the above hack removed) before attempting to support all node.js modules.