Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing extra bracket and missing paren in ext-py/parquet/bitstring.py #206

Merged
merged 1 commit into from
Jul 15, 2015
Merged

fixing extra bracket and missing paren in ext-py/parquet/bitstring.py #206

merged 1 commit into from
Jul 15, 2015

Conversation

c6stephens
Copy link
Contributor

It looks like this file has an extra ] and a missing (.

This file doesn't compile under Python 2.7:

$ python desktop/core/ext-py/parquet-python/parquet/bitstring.py
  File "desktop/core/ext-py/parquet-python/parquet/bitstring.py", line 4
    ]
    ^
SyntaxError: invalid syntax
$ python desktop/core/ext-py/parquet-python/parquet/bitstring.py
  File "desktop/core/ext-py/parquet-python/parquet/bitstring.py", line 19
    byte_index, bit_offset = divmod(self.offset + key), 8)
                                                         ^
SyntaxError: invalid syntax

Interestingly, the ] bracket was deleted upstream, but the ( paren wasn't added?

I've started a pull request upstream.

romainr added a commit that referenced this pull request Jul 15, 2015
[core] fixing extra bracket and missing paren in ext-py/parquet/bitstring.py
@romainr romainr merged commit 0a6d7b0 into cloudera:master Jul 15, 2015
@romainr
Copy link
Contributor

romainr commented Jul 15, 2015

Thanks!

Nice catch and thanks for also doing the upstream pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants