Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUT-10341 Add support for multiple dirs when reading config from fs #4

Merged
merged 5 commits into from
Jan 10, 2024
Merged

AUT-10341 Add support for multiple dirs when reading config from fs #4

merged 5 commits into from
Jan 10, 2024

Conversation

piotrek-janus
Copy link
Contributor

Jira task - https://cloudentity.atlassian.net/browse/AUT-10341

Release Notes Description (public)

Adds support to read configuration from multiple directories.

It is required to support configuration shared between different environments like:

  • dev - development env configuration
  • prod - production configuration
  • base - configuration shared between dev and prod

It can be configured as below:

(.env-dev)
storage:
  dir_path: ["/var/dev", "/var/base"]

(.env-prod)
storage:
  dir_path: ["/var/prod", "/var/base"]

The configurations are merged in the reversed order so anything in front of the list has a higher priority.

Implementation details (internal)

Information for QA

  • Is QA testing required?
  • Does PR contain unit tests?
  • Should QA create E2E tests for the change?

Additional QA Procedures (Optional)

Screenshots (if appropriate):

@piotrek-janus piotrek-janus requested a review from a team as a code owner January 8, 2024 15:32
@piotrek-janus piotrek-janus merged commit 40c0f16 into dev Jan 10, 2024
3 checks passed
@piotrek-janus piotrek-janus mentioned this pull request Jan 10, 2024
Merged
piotrek-janus added a commit that referenced this pull request Jan 10, 2024
@piotrek-janus
AUT-10341 Add support for multiple dirs when reading config from fs (#4…
7c4b76b 
…) (#5)

* add support for multiple dirs when reading config from fs

* readme

* fix passing multiple paths as env variable

* readme

* logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikawalec ikawalec ikawalec approved these changes

@mbilski mbilski mbilski approved these changes

@jdabrowski jdabrowski Awaiting requested review from jdabrowski jdabrowski is a code owner automatically assigned from cloudentity/go

@bwereszczak bwereszczak Awaiting requested review from bwereszczak bwereszczak is a code owner automatically assigned from cloudentity/go

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrek-janus @mbilski @ikawalec