Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do only some API resource routes receive names? #43

Closed
GregPeden opened this issue Feb 24, 2017 · 6 comments
Closed

Why do only some API resource routes receive names? #43

GregPeden opened this issue Feb 24, 2017 · 6 comments

Comments

@GregPeden
Copy link
Contributor

Referencing the wiki here...
https://github.com/cloudcreativity/laravel-json-api/wiki/Routing#route-names

Is there a reason why the other created resource routes don't receive a name? It seems to me that they might as well.

@lindyhopchris
Copy link
Member

Do you mean add names for the different methods? At the moment the list of names matches the list or URLs that are registered.

@GregPeden
Copy link
Contributor Author

Yes but there are all of the other method types on those URLs which don't receive names.

https://github.com/cloudcreativity/laravel-json-api/wiki/Routing#urls-and-controller-methods

@lindyhopchris
Copy link
Member

I suppose I just added the ones that are needed to generate the JSON API LinkInterface classes. But you are right, there should probably be names for all of the different options.

@GregPeden
Copy link
Contributor Author

For what it's worth, here is a package which would be a compliment to this package for client-side management of named routes if all API routes had proper names. Right now it cannot be used properly with this package if named routes is intended.
https://github.com/aaronlord/laroute

@lindyhopchris
Copy link
Member

Yep, I've added the route names for all the routes to the registrar refactor that I've done on the feature/issue53 branch. It's not ready to use yet though as it's linked to some other refactoring that needs to be done.

@lindyhopchris
Copy link
Member

The new routing now has names for all routes. This has been merged into develop and will be released in v0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants