Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'getRouteKeyName' for Cursor Paging Strategy #237

Closed
dimitvassilev opened this issue Oct 8, 2018 · 1 comment
Closed

'getRouteKeyName' for Cursor Paging Strategy #237

dimitvassilev opened this issue Oct 8, 2018 · 1 comment
Labels
bug
Milestone
1.0.0

Comments

@dimitvassilev
Copy link

Hi Chris,

Just an enhancement suggestion - as the package now uses the getRouteKeyName model method as default JSON API id, I think it would be better to use it in the CursorBuilder::guessKey() method as well instead of the getKeyName one.

Cheers!
@lindyhopchris
Copy link
Member

Ah yes, good spot. Will get that changed.

@lindyhopchris lindyhopchris added this to the 1.0.0 milestone Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@lindyhopchris @dimitvassilev