Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge AbstractSortedSearch into AbstractSearch #16

Closed
lindyhopchris opened this issue Aug 26, 2016 · 1 comment
Closed

Merge AbstractSortedSearch into AbstractSearch #16

lindyhopchris opened this issue Aug 26, 2016 · 1 comment
Milestone

Comments

@lindyhopchris
Copy link
Member

There's no requirement to have both AbstractSearch and AbstractSortedSearch - it would be simpler to merge the child into the parent. If someone wants to implement their own sort method, they can always override the sort method anyway.

Searching can be disabled by not allowing the client to send any sort parameters anyway - i.e. through the request definition.

@lindyhopchris lindyhopchris added this to the 0.5.0 milestone Aug 26, 2016
@lindyhopchris
Copy link
Member Author

Closing as this is available via Componser on the v0.5.x-dev release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant