-
Notifications
You must be signed in to change notification settings - Fork 34
[JENKINS-26481] Generate CpsDefaultGroovyMethods, invoke using GroovyCategorySupport #56
Conversation
… to DefaultGroovyMethods. Using GroovyCategorySupport rather than trying to fix DGMPatcher. Using a generated copy of CpsDefaultGroovyMethods.
I was wondering what happened there... |
Sideporting tests for collect, each and collectEntries
…ing code generation to delegate to untranslated public methods when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think we need sort
- it's too obvious a method to use once we've got each
, collect
, etc... I know it's some work, but I think of the things that are not yet translated, that's the most important.
I'm also not sure whether we should hold this until StringGroovyMethods
is ready too - I think we can probably wait on it, but it feels like we might as well do it now while we're here?
Well I do not know how to implement W.r.t. |
Ok, sounds reasonable on both counts. |
@reviewbybees done |
I accidentally merged #54 and it seems GitHub offers no way to unmerge a PR.
Pulls the category trick down from jenkinsci/workflow-cps-plugin#124 (and should become upstream of that if all works out).
Implements #7, picking up artifacts from cloudbees/groovy-cps-dgm-builder#4 (ideally this would be automated by Maven but for now it is manual).
Supersedes #52 (though the expanded tests could be sideported).
@reviewbybees