Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes: Fix formatting in the controls document #20

Open
pratiklotia opened this issue Sep 2, 2022 · 2 comments
Open

Minor changes: Fix formatting in the controls document #20

pratiklotia opened this issue Sep 2, 2022 · 2 comments

Comments

@pratiklotia
Copy link
Collaborator

When the controls doc was imported to csv, we overlooked that some controls are split on two lines instead of one. For example, in the document here: https://raw.githubusercontent.com/cloud-native-security-controls/controls-catalog/main/controls/controls_catalog_v1.0.csv, between ID 10 and 11, the NIST mapping is actually on a different line. Thankfully, this is not affecting the rendering of the doc but creates confusion when we are making changes to the raw document. There are quite a few such cases where the controls are split on separate lines. It can be easily seen in the PR https://github.com/cloud-native-security-controls/controls-catalog/pull/18/files --- line 11, 18, 33, etc.

@pratiklotia
Copy link
Collaborator Author

pratiklotia commented Sep 2, 2022

This is a good first issue for any new contributors in the team.

@JonZeolla
Copy link
Member

@pratiklotia did you have a suggestion; like don't use newlines in any field? I noticed this but since it rendered fine using double quotes I left it as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants