Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows CI #324

Closed
rbradford opened this issue Mar 18, 2024 · 1 comment · Fixed by #328
Closed

Windows CI #324

rbradford opened this issue Mar 18, 2024 · 1 comment · Fixed by #328
Assignees
@retrage

Comments

@rbradford
Copy link
Member

We can now self hosted runners which gives us enough disk space to re-enable Windows CI (using runner name "garm-jammy-16"). However since a secret needs to be used to download the image and forks do not have access to secrets we need to decide whether to go with merge queue approach (like Cloud Hypervisor) or only test Windows after it has already been pushed to main.

@retrage What would your preference be?
@retrage retrage self-assigned this Mar 19, 2024
@retrage
Copy link
Contributor

retrage commented Mar 19, 2024

@rbradford I prefer to use the merge queue approach, because we can detect a breaking change for the Windows guest boot before merging to the main branch. I'll create a GHA workflow for the Windows CI.

retrage added a commit to retrage/rust-hypervisor-firmware that referenced this issue Mar 20, 2024
@retrage
ci: Add Windows guest integration tests for GHA
c44c9cc 
Resolves cloud-hypervisor#324

Signed-off-by: Akira Moroo <[email protected]>
@retrage retrage mentioned this issue Mar 20, 2024
Merged
retrage added a commit to retrage/rust-hypervisor-firmware that referenced this issue Mar 20, 2024
@retrage
ci: Add Windows guest integration tests for GHA
ec27699 
Resolves cloud-hypervisor#324

Signed-off-by: Akira Moroo <[email protected]>
retrage added a commit to retrage/rust-hypervisor-firmware that referenced this issue Mar 20, 2024
@retrage
ci: Add Windows guest integration tests for GHA
04d49b6 
Resolves cloud-hypervisor#324

Signed-off-by: Akira Moroo <[email protected]>
retrage added a commit to retrage/rust-hypervisor-firmware that referenced this issue Mar 22, 2024
@retrage
ci: Add Windows guest integration tests for GHA
c165435 
Resolves cloud-hypervisor#324. It also updates the Windows guest image from Windows 2019
to Windows 2022.

Signed-off-by: Akira Moroo <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Mar 22, 2024
@retrage @rbradford
ci: Add Windows guest integration tests for GHA
95cb8b0 
Resolves #324. It also updates the Windows guest image from Windows 2019
to Windows 2022.

Signed-off-by: Akira Moroo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@retrage retrage

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Add Windows guest integration tests for GHA retrage/rust-hypervisor-firmware
2 participants
@rbradford @retrage