Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backstage plugin recommendations table #78

Open
2 tasks done
ccasher opened this issue Aug 3, 2023 · 2 comments
Open
2 tasks done

fix backstage plugin recommendations table #78

ccasher opened this issue Aug 3, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ccasher
Copy link
Contributor

ccasher commented Aug 3, 2023

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

With the recent updates to the backstage plugin - the recommendations table is difficult to see. There may have been a UI related problem with mui when we updated the ccf client package to React 18.

Expected Behavior

When loading the ccf backstage plugin and going to the recommendations page, i should be able to clearly see the table.

Actual Behavior

The table component renders, but is difficult to see with the UI styling

To Reproduce

Create a backstage instance, add the ccf plugin and navigate to the recommendations page

Screenshots

Screenshot 2023-08-03 at 4 36 48 PM

© 2021 Thoughtworks, Inc.

@ccasher ccasher added the bug Something isn't working label Aug 3, 2023
@ccasher ccasher transferred this issue from cloud-carbon-footprint/cloud-carbon-footprint Aug 3, 2023
@ccasher ccasher moved this from 📝 Backlog to 🔖 Ready To Do in Cloud Carbon Footprint Project Board Aug 3, 2023
@ccasher ccasher added the help wanted Extra attention is needed label Aug 4, 2023
@tudi2d
Copy link

tudi2d commented Aug 17, 2023

hej @ccasher - some context on this: Backstage is not yet compatible with React 18 (but hopefully will be soon backstage/backstage#18243). Looking at your RecommendationsTable it seems like you are using @mui/x-data-grid, which depends on @mui/material (Docs). For a better support maybe try the following:

  • Upgrade Backstage to v1.17.0
  • Use the UnifiedTheme Provider to support Material UI v4 and v5 at the same time
  • Allow React 17 for compatibility & see if that would work for CCF
    "peerDependencies": {
     "react": "^17.0.0 || ^18.0.0",
     "react-dom": "^17.0.0 || ^18.0.0"
    },

Also: Always feel free to reach out (here or on Discord/Slack) whenever you run into problems with Backstage while developing this plugin. Happy to help out.

@4upz
Copy link
Member

4upz commented Aug 18, 2023

Thanks @tudi2d! We'll give this a try and see if that helps resolve the issue. We'll definitely reach out if we still run into any trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: 🔖 Ready To Do
Development

No branches or pull requests

3 participants