Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the honeybee models and synchronization script #86

Merged
merged 1 commit into from
May 27, 2024
Merged

Update the honeybee models and synchronization script #86

merged 1 commit into from
May 27, 2024

Conversation

ish-hcc
Copy link
Member

@ish-hcc ish-hcc commented May 24, 2024 •
edited
Loading

Honeybee의 변경사항으로 인해 모델을 수집하는 과정에서 발생하는 문제를 수정하였습니다.

  • get-onprem-models.sh 스크립트 수정
  • Honeybee Model 변경 사항 업데이트
  • Swagger 업데이트

@yunkon-kim
Copy link
Member

@ish-hcc 직접 PR까지 올려주셨네요 ^^ 감사합니다.

#85 draft PR과도 관련이 있고 CI failed 상태이기도 해서요. 이후 작업은 제가 넘겨받아 진행하는 편이 좋을 것 같습니다.

진행 중에 문의사항이 발생하면 연락 드리겠습니다.

@yunkon-kim yunkon-kim changed the title Fix issue of getting honeybee models Update the honeybee models and synchronization script May 27, 2024
yunkon-kim
yunkon-kim approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@yunkon-kim yunkon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ish-hcc LGTM!

참고 - 몇 가지 마이너한 이슈는 별도의 PR에서 해결될 예정입니다.

@yunkon-kim yunkon-kim merged commit 581dd28 into cloud-barista:main May 27, 2024
0 of 2 checks passed
@ish-hcc
Copy link
Member Author

ish-hcc commented May 27, 2024

@yunkon-kim 네 감사합니다!

@yunkon-kim yunkon-kim linked an issue May 30, 2024 that may be closed by this pull request
Method to synchronize source or destination model #42
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunkon-kim yunkon-kim yunkon-kim approved these changes

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method to synchronize source or destination model
2 participants
@ish-hcc @yunkon-kim