Fix 1941 and validate naming rule #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2024 09:55
In the case of Azure, dashes are not allowed in node pool names. For more details, refer to https://aka.ms/aks-naming-rules.
|
/approve |
github-actions
bot
added
the
approved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
본 PR은 #1941 이슈를 해결하고,
Azure에서 node group name의 제약이 발생하는 것을 사전에 방지하기 위해 assets/k8sclusterinfo.yaml에 등록된 regular expression을 체크합니다.
In the case of Azure, dashes are not allowed in node pool names.
For more details, refer to https://aka.ms/aks-naming-rules.