Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One file is not gofmt-ed #680

Closed
jihoon-seo opened this issue Aug 19, 2021 · 3 comments · Fixed by #693
Closed

One file is not gofmt-ed #680

jihoon-seo opened this issue Aug 19, 2021 · 3 comments · Fixed by #693
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jihoon-seo
Copy link
Member

What would you like to be enhanced
:
gofmt a file:
cb-tumblebug/src/api/grpc/request/test/test_api.go

Why is this needed
:
Go Report Card is saying:

cb-tumblebug/src/api/grpc/request/test/test_api.go
Line 1: warning: file is not gofmted with -s (gofmt)

Proposed solution
:
gofmt that file and open a PR.

(e.g. Open that file with VScode (gofmt-enabled),
click "Save" (then gofmt will gofmt automatically),
and open a PR.)

@jihoon-seo jihoon-seo added enhancement New feature or request good first issue Good for newcomers labels Aug 19, 2021
@seokho-son seokho-son added the help wanted Extra attention is needed label Aug 19, 2021
@atg0831
Copy link
Member

atg0831 commented Aug 30, 2021

제가 gofmt으로 파일 저장하고 PR 요청해도 될까요?

@seokho-son
Copy link
Member

물론입니다^^

@seokho-son
Copy link
Member

/assign @atg0831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants