Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update source codes to comply with golint #654

Closed
seokho-son opened this issue Aug 2, 2021 · 5 comments
Closed

Update source codes to comply with golint #654

seokho-son opened this issue Aug 2, 2021 · 5 comments
Assignees
@computerphilosopher
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@seokho-son
Copy link
Member

seokho-son commented Aug 2, 2021 •
edited
Loading

What would you like to be added
: golint 를 준수하도록 코드 개선 (Golint is a linter for Go source code)

Why is this needed
: golint 를 준수하여 코드 가독성 및 관리 효율 향상

[Tasks: cb-tumblebug Go report card 참고]
https://goreportcard.com/report/github.com/cloud-barista/cb-tumblebug#golint
@seokho-son seokho-son added the feature request Issue related with new feature label Aug 2, 2021
@seokho-son
Copy link
Member Author

/help

@seokho-son seokho-son added good first issue Good for newcomers help wanted Extra attention is needed enhancement New feature or request and removed feature request Issue related with new feature labels Aug 2, 2021
@seokho-son
Copy link
Member Author

seokho-son commented Aug 2, 2021 •
edited
Loading

세부 Task 로 함께 기여할 수 있습니다.. ^^
기여하실 분 손들어주세요~~

@computerphilosopher
Copy link
Member

가장 빨리 개선할 수 있는 부분이 naming 수정으로 보입니다. golang은 언더스코어를 쓰지 않고 카멜 케이스로 네이밍 하는 것을 권장하는데 이를 지키지 않은 경우가 꽤 있네요. 제가 한 번 개선해보겠습니다.

@seokho-son
Copy link
Member Author

@computerphilosopher 감사합니다!! ^^

@seokho-son
Copy link
Member Author

/assign @computerphilosopher

@jihoon-seo jihoon-seo mentioned this issue Aug 19, 2021
Closed
@computerphilosopher computerphilosopher mentioned this issue Aug 21, 2021
Merged
@jihoon-seo jihoon-seo mentioned this issue Sep 1, 2021
Closed
This was referenced Sep 10, 2021
Merged
Merged
@seokho-son seokho-son mentioned this issue Sep 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@computerphilosopher computerphilosopher

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seokho-son @computerphilosopher