Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vm control button for AdminWeb #483

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

jmleefree
Copy link
Member

resolve #477

  • XMLHttpRequest 의 HTTP GET 호출에서는 json body 를 포함하지 못하는 문제로 인하여 POST 방식의 "/controlvm/:Name" VM Handler 추가함
  • mock 환경에서 테스트함

@powerkimhub powerkimhub self-requested a review October 18, 2021 02:33
@powerkimhub
Copy link
Member

@jmleefree

  • 다시 생각해 보니,
  • 의미상 POST 보다 PUT이 맞을 듯 한데 어찌 생각하시나요?

@jmleefree
Copy link
Member Author

@powerkimhub
보통 POST 를 사용하면 creation 을 의미하고 PUT 은 update 를 할 때 사용하는 걸로 아는데..
상태를 변경하는 의미이니까 PUT 이 맞을 것 같네요..
PUT 으로 변경하겠습니다^^

@powerkimhub powerkimhub merged commit cf4224a into cloud-barista:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AdminWeb] Add buttons to control a VM
2 participants