Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grpc api for vpc subnet #327

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Add grpc api for vpc subnet #327

merged 2 commits into from
Jan 28, 2021

Conversation

jmleefree
Copy link
Member

  • VPC 서브넷을 위한 protobuf 추가
  • VPC 서브넷을 위한 grpc server 추가
  • VPC 서브넷을 위한 grpc client api 추가
  • VPC 서브넷을 위한 test api 추가
  • VPC 서브넷을 위한 cli 추가

@powerkimhub powerkimhub self-requested a review January 28, 2021 06:34
@powerkimhub
Copy link
Member

@jmleefree Thanks Thanks!!

  • 혹시, Test는 어떤 방법으로 했는지요?

@powerkimhub powerkimhub mentioned this pull request Jan 28, 2021
Closed
@jmleefree
Copy link
Member Author

기본적으로 Mock Driver 로 테스트했습니다.
그리고, grpc 의 경우 openstack 도 테스트 했습니다.
테스트 스크립트도 지금 올릴까요?

@powerkimhub
Copy link
Member

@jmleefree

  • 멋지네요^^
  • 테스트 스크립트가 기존 repos에 존재하는 시험 스크립트와 유사한 가요?
  • 그렇다면 함께 올려주시면 좋을 듯합니다.

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 26 Code Smells

No Coverage information No Coverage information
29.0% 29.0% Duplication

@powerkimhub
Copy link
Member

@jmleefree Thanks for your contributions!! 👍

@powerkimhub powerkimhub merged commit 73cc3a1 into cloud-barista:master Jan 28, 2021
@jmleefree jmleefree deleted the add-subnet-grpc-api branch March 24, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerkimhub powerkimhub powerkimhub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmleefree @powerkimhub