fix: compatability with docusaurus 2.2.0 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docusaurus-openapi ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bourdakos1
approved these changes
Nov 8, 2022
|
Thanks for the quick review 🙂 note for future context, we could probably update the But this fix unblocks the 2.2.0 support for now until we gather more use cases for that change. |
Merged
|
Thanks so much! |
slorber
reviewed
Nov 9, 2022
| @@ -274,6 +274,8 @@ export default function pluginOpenAPI( | |||
| rehypePlugins, | |||
| beforeDefaultRehypePlugins, | |||
| beforeDefaultRemarkPlugins, | |||
| // Docusaurus 2.2.0 has a regression that requires this option to be set. | |||
| markdownConfig: {}, | |||
There was a problem hiding this comment.
I would rather pass markdownConfig: context.siteConfig.markdown: this is what all other plugins do, and third-party plugin authors using our mdx loader should rather do the same to apply global markdown config for all md docs. There will be more Markdown site options in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new property option that was introduced in v2.2.0 of
@docusaurus/mdx-loader.Resolves #222
Related Docusaurus issue: facebook/docusaurus#8298