-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lxml is required #9
Comments
It's an optional dependency. If you're just interested in parsing plain text emails, you don't need to install it. |
It should at least be documented. Getting an ImportError when deploying is not the greatest way to find out such things. |
Where? The README already says:
|
Aha, I am stupid and didn't see that. I still think adding it to setup.py is the right approach, but it's not a particularly strongly held opinion. |
I just don't want to make it a mandatory dependency. Also, your tests should have caught it before deploying it. |
Feel free to reopen if you have specific suggestions on how to make it clearer, keeping in mind that libxml should stay as an optional dependency |
In order to parse html emails, lxml is required. This should be added to setup.py.
The text was updated successfully, but these errors were encountered: