cljr-clean-ns with incanter.core/$

[aiba]

incanter.core has a symbol $, which when referred breaks cljr-clean-ns.

(ns test.hello
  (:require [incanter.core :refer [$]]))

$

You can see real usage of the $ function here.

Expected behavior

cljr-clean-ns should complete without throwing an error.

Actual behavior

cljr--maybe-rethrow-error: Can’t create a fully qualified symbol from: ’incanter.core’ and  ’’

Environment & Version information

clj-refactor 2.3.0-SNAPSHOT (package: 20170126.118), refactor-nrepl 2.3.0-SNAPSHOT
CIDER 0.15.0snapshot (package: 20170129.1941)
Clojure 1.8.0
Leiningen 2.7.1 on Java 1.8.0_112
GNU Emacs 25.1.1 (x86_64-apple-darwin13.4.0, Carbon Version 157 AppKit 1265.21) of 2016-11-05
OS X 10.12.3

[expez]

Without even looking at the code I have a fairly good guess what happens.

The $ is used in the names of inner classes on the jvm so we split on it to find out if the inner class is used, but in this case that doesn't leave anything else.

Thanks for the report, this is likely to be easy to fix.

[xiongtx]

Seems like this breaks with all inner classes, e.g. org.apache.avro.Schema$Parser is removed even if (Schema$Parser.) appears in the code.

[expez]

If that's true that's a serious regression. Surprised the pertinent integration tests are still green...

[benedekfazekas]

fix deployed to clojars