Upgrade clojure.tools.reader to support namespaced map literals

[plexus]

And one more :)

clean-ns was failing on namespaces that contain Clojure 1.9 style namespaced maps. Because the included version of tools reader was pretty far out of date. This bumps the version from 0.10.0-alpha3 to 1.0.0-beta4. Namespaced maps are supported since tools.reader 1.0.0-beta3.

Is there a general policy on when to bump dependencies? There are quite a few that could be updated. Also, would it make sense to add a :1.9 profile to test for Clojure 1.9 compatibility?

• All tests are passing (run lein do clean, test)
• Code inlining with mranderson works and tests pass with inlined code (run ./build.sh install -- takes a long time)
• You've updated the changelog (if adding/changing user-visible functionality)

Thanks!

[expez]

Is there a general policy on when to bump dependencies? There are quite a few that could be updated.

The only goal we have is to be backward compatible as far back as is reasonably possible. So far this has meant back to 1.7.

Also, would it make sense to add a :1.9 profile to test for Clojure 1.9 compatibility?

For sure

[benedekfazekas]

LGTM

[benedekfazekas]

Also, would it make sense to add a :1.9 profile to test for Clojure 1.9 compatibility?

👍 also would be nice to add this to the test matrix in the build file. however the build already takes like 10 mins we should probably look into it and make it a bit snappier (long build is fine on travis but a bit annoying when developing, checking PRs etc)

[expez]

Thanks! 👍

[magnars]

Oh, very nice! I need this. :) Any chance for a new snapshot release?

By the way, I tried lein with-profile plugin.mranderson/config install, but I ended up getting:

WARNING: clj-refactor and refactor-nrepl are out of sync.
Their versions are 2.3.0-SNAPSHOT and n/a, respectively.

And no refactor middleware.

[expez]

@magnars I got that after upgrading CIDER at home, but it seemed to work anyway. We rely on cider's code to display these warnings...

I'll push a snapshot later today if @benedekfazekas doesn't beat me to it.

[magnars]

@expez I hoped that would be the case as well, but got this warning when trying to use it: user-error: The refactor-nrepl middleware isn't available! Did you remember to install it?

[benedekfazekas]

will try to beat @expez ;)

but meanwhile try ./build.sh install @magnars

[benedekfazekas]

or else just run
lein do clean, source-deps :prefix-exclusions "[\"classlojure\"]"
before running
lein with-profile plugin.mranderson/config install

(./build.sh install should work too but running tests is kinda sloooow)

[benedekfazekas]

completely forgot about this. sry. shall i upload a snapshot version or already done and all parties are fine?
/cc @magnars @expez

[expez]

Go for it @benedekfazekas :)

[plexus]

thanks, that'd be great. Maybe a "real" release would also be nice at some point. Some of these fixed bugs are really annoying when you happen to run into them.

[benedekfazekas]

snapshot release: on it.

we are one issue away from 2.3.0 afaik

[benedekfazekas]

new 2.3.0-snapshot is on clojars