-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find-symbol fails when the project contains cljc files #108
Comments
Guessing there's a |
Yes, there certainly is a |
So this is a regression as part of @benedekfazekas work on taming the macro AST beast? |
No, we've never had support for anything but |
So not only don't we support |
yes, if you have time you can tell the reader to accept reader macros and see what happens. Depending on your project you might get some value out of just following the |
This certainly did work before the summer, 4 weeks ago. I didn't expect it to work in |
Conditional read not allowed
?
Somewhat hard to admit this is a bug, because I didn't worry about cljc when writing the code:p Putting a hack in place to get this to work like before should be pretty easy. |
I guess the issue here is that I just want to inline a local let, and you have to traverse the entire project to find that out. But yeah, it might not be a bug, it might be by design, but it's still a regression. :) |
yes this does suck. Initially I tried to do This means we might have introduced a performance regression too, but I'm not sure it matters because the work done to find macros appear to be a lot less than what v1 of the macro code also doesn't do any caching, so if there's a performance regression, that would certainly be a cheap win. Most likely easier than figuring out why we get spurious results for macros using the AST based search anyway. |
Thanks! :) |
new snapshot deployed |
This happens whenever I try to use rich refactorings like find-usages, inline-symbol and its ilk:
Ideas?
The text was updated successfully, but these errors were encountered: