[Fix #384] Add cljr-auto-sort-project-dependencies

[raxod502]

• Add new defcustom cljr-auto-sort-project-dependencies, defaults to nil.
• Add new function cljr--maybe-sort-project-dependencies.
• Call new function from cljr-add-project-dependency.
• Update changelog.

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• The new code is not generating byte compile warnings (run cask exec emacs -batch -Q -L . -eval "(progn (setq byte-compile-error-on-warn t) (batch-byte-compile))" clj-refactor.el)
• All tests are passing (run ./run-tests.sh)
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the readme (if adding/changing user-visible functionality)
  • No, as existing variable cljr-auto-sort-ns was not documented there

[expez]

Cool. This looks good! I'd like to have a test for this, so I'll hold off a little and see what comes of that cask issue.

[raxod502]

The Cask issue has disappeared. You can therefore expect some tests to be added here once I get free time.

[expez]

Great 👍

[expez]

Ping @raxod502

[raxod502]

Indeed, I'm sorry I still haven't got to this. The only time I can really be sure I will have time is at the end of the semester during winter break. It's on my shortlist.

[raxod502]

Sigh. Just when I have some time to work on this, Cask produces more trouble for me: cask/cask#418

Nowadays, I'm experienced enough to work around the problem, so this shouldn't prevent me from adding tests to this pull request.

[raxod502]

I added some preliminary tests. For some reason, adding them causes 54 unrelated tests to fail. This boggles my mind. Any idea what's up?

Also, is there any good way to debug the test suite? It seems pretty impenetrable to me, especially given that ecukes --pattern does not seem to actually do any pattern-matching.

[expez]

I don't have any good tips in dealing with ecukes. It's been a huge time sink for me over the years too.

[bbatsov]

Why not just kill it?

…

On Fri, Mar 16, 2018 at 15:14 Lars Andersen ***@***.***> wrote: I don't have any good tips in dealing with ecukes. It's been a huge time sink for me over the years too. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#385 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGVyjDZVsFOOtWSF2QgiPN51Ye4G21Iks5te3RogaJpZM4Ob0W5> .

[expez]

Why not just kill it?

They still provide value, even if they are a bitch to deal with when something goes wrong, and nobody is interested in re-writing the test suite.

[raxod502]

@expez What do you recommend? I can't proceed farther with the tests without the ability to debug things, unfortunately.

[expez]

@raxod502 The first test that's failing is the one for the new feature. It fails with Wrong type argument: stringp, nil. Have you tested that the new feature works manually?

The ecukes tests are pretty fragile, so I'm guessing that if you fix the first failing test all the others will fall in line.

I can't remember what works best for debugging, but you can do side-effecting stuff to debug (e.g. write to a temp file with checkpoints to close in on the offending line) or IIRC you can throw errors and have them show up in the ecukes output.

Sorry about the painful test suite :(

[raxod502]

I finally got some time to look at this, only to find that the test suite fails on the latest master from a clean build, too.

See tests.log.

I can't debug this test if other ones are failing.

[raxod502]

Ping.

[expez]

Build has been fixed

[bbatsov]

@raxod502 Ping :-)

[raxod502]

Thanks for the reminder. I have since started the fall semester at Harvey Mudd College, and likely won't have time to work on this for at least a few months, unfortunately. It remains on my to-do list, however.

[manuel-uberti]

Any chance for this? :)

[raxod502]

Sorry, I've long since stopped using Clojure and clj-refactor.el, and I have a lot of other projects that need attention. I'll close this pull request unless someone else would like to adopt it.