Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cider-jump fails when nrepl server isn't local #589

Closed
hugoduncan opened this issue May 29, 2014 · 9 comments
Closed

cider-jump fails when nrepl server isn't local #589

hugoduncan opened this issue May 29, 2014 · 9 comments

Comments

@hugoduncan
Copy link
Member

The cider-jump command looks for symbols in local jar files, rather than in jar files on the nrepl server.
@bbatsov
Copy link
Member

bbatsov commented May 29, 2014

@jeffvalk, would you please have a look at this?

@gtrak
Copy link
Contributor

gtrak commented May 29, 2014

@tpope added a 'resource' info key for this use-case in vim.

On Thu, May 29, 2014 at 7:17 AM, Bozhidar Batsov
[email protected]:

@jeffvalk https://github.com/jeffvalk, would you please have a look at
this?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/589#issuecomment-44522078
.

@jeffvalk
Copy link
Contributor

@bbatsov Is this not the intent of cider-use-local-resources? The tramp usage in CIDER isn't anything I'm too familiar with...

@bbatsov
Copy link
Member

bbatsov commented May 29, 2014

@jeffvalk Frankly, I'm not particularly familiar with the tramp usage myself. I might eventually get to check this, but these days I'm mostly trying to figure out problems like #583 and #587. I found so many problems with the existing code in nrepl-client.el, that I'm feeling pretty down right now...

@jeffvalk
Copy link
Contributor

@bbatsov I hear you loud and clear. I'll give this one a look (it's also somewhat related to #552, which I'd like a clean solution for). At the moment, I don't have a non-local server handy to investigate though.

@hugoduncan Could you try (setq cider-use-local-resources nil) and see if the current tramp behavior works for your original test case?

@hugoduncan
Copy link
Member Author

Setting cider-use-local-resources to nil causes things to work correctly. Is there any rationale for having the default as t?

Note that this isn't just related to tramp usage - it is possible to connect to a remote repl without using tramp.

@jeffvalk
Copy link
Contributor

Possibly to avoid transport of large files over a constrained network connection -- but that's just a guess. (For instance, if you're VPN-ed in remotely, cider-jump into the 40+MB JDK src.zip might hurt.)

For reference, it looks like that feature was introduced in a9763ea. It also looks like having the cider-use-local-resources flag set does not prevent the remote resource from being resolved; it just prefers a local one if one exists. @hugoduncan Is this true in your case?

jeffvalk added a commit to jeffvalk/cider that referenced this issue Jun 1, 2014
@jeffvalk
[Fix clojure-emacs#589] Don't preference home directory resources to …
437b7e3 
…tramp by default.

Rename `cider-use-local-resources` to `cider-prefer-local-resources` and
set default value to nil.

Rename `cider-emacs-or-clojure-side-adjustment` to `cider-file-path` for
clarity (and brevity!).
@bbatsov bbatsov closed this as completed in 71e015a Jun 1, 2014
dgtized pushed a commit to dgtized/cider that referenced this issue Jun 24, 2014
@jeffvalk @dgtized
[Fix clojure-emacs#589] Don't prefer local paths over tramp by default.
e8f1f9d 
Rename `cider-use-local-resources` to `cider-prefer-local-resources` and
set default value to nil.

Remove `cider-home-prefix-adjustment`. It was unnecessary, and a bug in
`cider-emacs-or-clojure-side-adjustment` prevented it working
as (apparently) designed anyway.

Rename `cider-emacs-or-clojure-side-adjustment` to `cider-file-path` for
clarity (and brevity!).
@lsgrep
Copy link

lsgrep commented Jan 25, 2015

Is it possible to view source code while connecting to remote REPL? I am getting "No source Location".

@jiacai2050
Copy link
Contributor

jiacai2050 commented Apr 28, 2017 •
edited
Loading

I have the same question with @c4ravan.

Would anyone look into this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@hugoduncan @jeffvalk @bbatsov @gtrak @jiacai2050 @lsgrep