Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadow-select CLJS REPL type #2397

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

arichiardi
Copy link
Contributor

Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • All code passes the linter (make lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

This kind of CLJS REPL is very helpful for cases when you are already watching
one or more shadow builds in shadow either after having launched the server in
a terminal or from within Cider.
This patch also refactors option normalization out of figwheel-main so that it
can be reused by every other function.

@arichiardi arichiardi force-pushed the add-shadow-select branch 2 times, most recently from e2f0d95 to 96c7df2 Compare August 2, 2018 18:33
This kind of CLJS REPL is very helpful for cases when you are already watching
one or more shadow builds in shadow either after having launched the server in
a terminal or from within Cider.
This patch also refactors option normalization out of figwheel-main so that it
can be reused by every other function.
@bbatsov bbatsov merged commit c4313db into clojure-emacs:master Aug 2, 2018
@bbatsov
Copy link
Member

bbatsov commented Aug 2, 2018

There's a bit of duplication in the two functions, but I guess I can live with this. Thanks!

Btw, a better approach might be to prompt people if they want to watch and select or simply select. That might eliminate potential confusion around having two similarly named REPL types.

@arichiardi arichiardi deleted the add-shadow-select branch August 2, 2018 19:46
@arichiardi
Copy link
Contributor Author

Oh good idea I would just avoid to prompt twice though, so maybe some other defcustom could be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants