-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render diffs for expected / actual test results #2172
Conversation
e750f6f
to
3eaec91
Compare
Looks pretty cool! Just two notes from me:
This change also requires a changelog entry. |
Arguably better than currently:
I was vaguely aware of it, but Ediff:
Try w/: (deftest diff-test
(is (= {:a 1 :b 2}
{:a 2 :b 3}
{:b 4 :c 5})))
|
@xiongtx I'm sold. :-) |
CHANGELOG.md
Outdated
@@ -2,6 +2,8 @@ | |||
|
|||
## master (unreleased) | |||
|
|||
* [#2172](https://github.com/clojure-emacs/cider/pull/2172): Render diffs for expected / actual test results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be under "New Features". :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
CHANGELOG.md
Outdated
@@ -4,6 +4,10 @@ | |||
|
|||
### New features | |||
|
|||
* [#2172](https://github.com/clojure-emacs/cider/pull/2172): Render diffs for expected / actual test results. | |||
|
|||
### New features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant to remove this - now we have two "New features" sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ ✅
Renders diffs provided by clojure-emacs/cider-nrepl#478 in test result buffer.