Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use view-mode for cider-grimoire buffer #2050

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Use view-mode for cider-grimoire buffer #2050

merged 1 commit into from
Jul 17, 2017

Conversation

xiongtx
Copy link
Member

@xiongtx xiongtx commented Jul 17, 2017

@xiongtx xiongtx force-pushed the grimoire-view-mode branch from 64e631b to 186a337 Compare July 17, 2017 02:22
@xiongtx xiongtx mentioned this pull request Jul 17, 2017
Closed
@bbatsov
Copy link
Member

bbatsov commented Jul 17, 2017

Please refer the ticket that this fixes in the commit message and update the changelog.

I wonder if we don't have other similar cases that might benefit from view-mode...

@xiongtx xiongtx force-pushed the grimoire-view-mode branch from 186a337 to d89c830 Compare July 17, 2017 07:23
@xiongtx
Copy link
Member Author

xiongtx commented Jul 17, 2017

Please refer the ticket that this fixes in the commit message and update the changelog.

Fixed.

I wonder if we don't have other similar cases that might benefit from view-mode...

Not as far as I can tell, unless you want all popup buffers to use view-mode, which I don't think should be the case.

@bbatsov bbatsov merged commit d55768a into clojure-emacs:master Jul 17, 2017
@xiongtx xiongtx deleted the grimoire-view-mode branch July 17, 2017 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiongtx @bbatsov