Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cider-docview-select-buffer custom variable #1995

Closed
wants to merge 1 commit into from
Closed

Added cider-docview-select-buffer custom variable #1995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cider-doc.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@
:group 'cider-docview-mode
:package-version '(cider . "0.7.0"))

(defcustom cider-docview-select-buffer t
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not really related to cider-docview-mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about changing group to cider-doc?

"Autoselect the documentation viewer after popup."
:type 'boolean
:group 'cider-docview-mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be cider-doc.

:package-version '(cider . "0.7.0"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it wasn't introduced in CIDER 0.7. :-)



;; Faces
Expand Down Expand Up @@ -263,7 +268,7 @@ opposite of what that option dictates."
(defun cider-doc-lookup (symbol)
"Look up documentation for SYMBOL."
(if-let ((buffer (cider-create-doc-buffer symbol)))
(cider-popup-buffer-display buffer t)
(cider-popup-buffer-display buffer cider-docview-select-buffer)
(user-error "Symbol %s not resolved" symbol)))

(defun cider-doc (&optional arg)
Expand Down