[Fix #1824] Cider-jack-in dependency exclusions #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| * [#1677](https://github.com/clojure-emacs/cider/issues/1677): Interpret `\r` as a newline. | |||
| * [#1819](https://github.com/clojure-emacs/cider/issues/1819): Handle properly missing commands on `cider-jack-in`. | |||
| * [#1824](https://github.com/clojure-emacs/cider/issues/1824): Can no longer jack-in to an inherited clojure version | |||
There was a problem hiding this comment.
I believe this can be phrased a bit better (and the sentence should end with a .).
|
Maybe this should also be mentioned somewhere in the manual? |
|
will add an explanation to the manual too |
|
I looked at installation.md where auto injecting cider dependencies is describe. I kinda feel now that this is a quite internal bugfix which should not interest users rather as I said above cider "plugin" authors. Happy to reconsider if you think adding something is necessary. |
Add option to define exclusions for injected dependecies. Add `org.cloure/clojure` exclusion to `org.clojure/tools.nrepl` to mitigate problem with tools.nrepl clojure dependency. Note about boot: the latest stable release does not support defining depedency exclusions on the command line. However, this feature is available in the upcoming 2.7.x release. This feature will be added for boot when 2.7.x is released.
benedekfazekas
force-pushed
the
jack-in-dependency-exclusions
branch
from
7b5a2ec to
f13fb56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test)M-x checkdocwarningsAdd option to define exclusions for injected dependecies. Add
org.cloure/clojureexclusion toorg.clojure/tools.nreplto mitigateproblem with tools.nrepl clojure dependency.
Note about boot: the latest stable release does not support defining
depedency exclusions on the command line. However, this feature is
available in the upcoming 2.7.x release. This feature will be added
for boot when 2.7.x is released.