-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More bug fixes from master for the 0.10.1 release #1491
Conversation
…cking. Update stack frame buttons to use `font-lock-face`. Create a button type that respects `font-lock-face`. By default, buttons use `'face`.
I'll keep this PR open for now, so we can add a bit more commits to it until the end of the week. Let's aim for a release of 0.10.1 early next week. I doubt that many people are at work between Christmas and New Year's Eve anyway, so the release is not super urgent. |
Enable test fail/error highlighting for forms at the beginning of a line with no preceding whitespace.
@bbatsov Sounds good. I'll keep pushing fixes until then. |
Great! |
We're good for a |
We'll also have to pull in the |
This should also be part of 0.10.1 #1500 |
@bbatsov Release schedule sounds good. Anything else I should bring in? What's your usual testing process for a release? I'm going to fire this code up locally and kick it around a bit, but would be happy to apply a more comprehensive process if you have one. |
Just do a bit of manual testing of the fixes we brought in. The process is quite simple - I tag and push. :-) |
|
@bbatsov I pushed that other commit you mentioned to cider-nrepl, but I haven't had a chance to test everything yet. |
OK, let me know when get to doing this. We'll probably add #1502 to 0.10.1 as well. |
#1435 looks good. |
Should we fix #1503 before releasing v0.10.1? |
@cap10morgan #1486 is fixed in the screenshots above, yes. |
Error buffer rendering must be in `cider-stacktrace-mode` to ensure required local variables are set.
That's working. :-) |
More bug fixes from master for the 0.10.1 release
I cut a new release, but it's probably broken due to an error in the middleware. The last commit backported there breaks the tests, but I noticed this too late and I didn't really have to investigate. I won't announce the release until we see what's wrong and I'll just swap the middleware jar. |
I'll start running this locally to see if I encounter any issues.