Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More bug fixes from master for the 0.10.1 release #1491

Merged
merged 15 commits into from
Jan 5, 2016

Conversation

cap10morgan
Copy link
Contributor

I'll start running this locally to see if I encounter any issues.

@bbatsov
Copy link
Member

bbatsov commented Dec 29, 2015

I'll keep this PR open for now, so we can add a bit more commits to it until the end of the week. Let's aim for a release of 0.10.1 early next week. I doubt that many people are at work between Christmas and New Year's Eve anyway, so the release is not super urgent.

@cap10morgan
Copy link
Contributor Author

@bbatsov Sounds good. I'll keep pushing fixes until then.

@bbatsov
Copy link
Member

bbatsov commented Dec 30, 2015

Great!

@bbatsov
Copy link
Member

bbatsov commented Jan 3, 2016

We're good for a clojure-mode 5.1 release tomorrow and we'll probably do the cider 0.10.1 release then as well.

@bbatsov
Copy link
Member

bbatsov commented Jan 3, 2016

We'll also have to pull in the cider-nrepl part of 44a7ced.

@bbatsov
Copy link
Member

bbatsov commented Jan 3, 2016

This should also be part of 0.10.1 #1500

@cap10morgan
Copy link
Contributor Author

@bbatsov Release schedule sounds good. Anything else I should bring in?

What's your usual testing process for a release? I'm going to fire this code up locally and kick it around a bit, but would be happy to apply a more comprehensive process if you have one.

@bbatsov
Copy link
Member

bbatsov commented Jan 3, 2016

Just do a bit of manual testing of the fixes we brought in. The process is quite simple - I tag and push. :-)

@bbatsov
Copy link
Member

bbatsov commented Jan 4, 2016

clojure-mode 5.1 is out!

@cap10morgan
Copy link
Contributor Author

@bbatsov I pushed that other commit you mentioned to cider-nrepl, but I haven't had a chance to test everything yet.

@bbatsov
Copy link
Member

bbatsov commented Jan 4, 2016

OK, let me know when get to doing this.

We'll probably add #1502 to 0.10.1 as well.

@cap10morgan
Copy link
Contributor Author

@bbatsov I don't personally use paredit (smartparens instead), so it might be good if someone else tested #1479.

@cap10morgan
Copy link
Contributor Author

OK, all but #1479 and #1435 are tested and seem to be working in this branch.

@cap10morgan
Copy link
Contributor Author

#1435 looks good.

@cap10morgan
Copy link
Contributor Author

Actually, I think #1486 is not fixed in this branch. It's still broken in this screenshot, no? @jeffvalk?

screen shot 2016-01-04 at 3 35 40 pm

Or maybe that's unrelated and the screenshot below is where the fix shows up?

screen shot 2016-01-04 at 3 39 04 pm

@cap10morgan
Copy link
Contributor Author

Should we fix #1503 before releasing v0.10.1?

@jeffvalk
Copy link
Contributor

jeffvalk commented Jan 5, 2016

@cap10morgan #1486 is fixed in the screenshots above, yes.

Error buffer rendering must be in `cider-stacktrace-mode` to ensure
required local variables are set.
@cap10morgan
Copy link
Contributor Author

Pulling in a7e5671 fixed #1503.

I think the only thing left is to have a paredit user test #1479 and then we should be good to go.

@bbatsov
Copy link
Member

bbatsov commented Jan 5, 2016

I think the only thing left is to have a paredit user test #1479 and then we should be good to go.

That's working. :-)

bbatsov added a commit that referenced this pull request Jan 5, 2016
More bug fixes from master for the 0.10.1 release
@bbatsov bbatsov merged commit b8589e0 into clojure-emacs:v0.10 Jan 5, 2016
@bbatsov
Copy link
Member

bbatsov commented Jan 5, 2016

I cut a new release, but it's probably broken due to an error in the middleware. The last commit backported there breaks the tests, but I noticed this too late and I didn't really have to investigate. I won't announce the release until we see what's wrong and I'll just swap the middleware jar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants