Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show cider-test-report buffer on test failures #719

Closed
r0man opened this issue Aug 8, 2014 · 3 comments
Closed

Only show cider-test-report buffer on test failures #719

r0man opened this issue Aug 8, 2014 · 3 comments

Comments

@r0man
Copy link
Contributor

r0man commented Aug 8, 2014

I think popping up the *cider-test-report* is only useful if
tests have actually failed. Most of the time I immedialtly close
that buffer again if tests were passing, and I think the
notification in the message buffer is enough.

If there is interest for this I can prepare a patch ...

Roman

@bbatsov
Copy link
Member

bbatsov commented Aug 8, 2014

Currently - yes. But if we display more information about the tests that were executed (which we'll probably do at some time) it might be more useful even for passing tests.

That said, I'm ok with making this configurable if @jeffvalk is ok as well.

@ikbrunel
Copy link

Seconded!

@bbatsov
Copy link
Member

bbatsov commented Aug 27, 2014

Fixed in #743.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants