Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Integrate CIDER doc displaying with quick-peek or inline-docs #1982

Closed
stardiviner opened this issue Apr 28, 2017 · 9 comments
Labels
feature request good first issue A simple tasks suitable for first-time contributors

Comments

@stardiviner
Copy link
Contributor

Hope CIDER can integrate quick-peek or inline-docs for functions like query docs.

This can be set in an option.

@bbatsov
Copy link
Member

bbatsov commented Apr 29, 2017

I'm assuming integrating something like this should be trivial, but unless a lot of people demand such a feature it should probably be implemented as a separate package, so that we don't introduce more dependencies to CIDER.

@stardiviner
Copy link
Contributor Author

I see, I will dive into CIDER source code to check out this. If have any question, will ask for help here. Thanks.

@bbatsov
Copy link
Member

bbatsov commented Apr 29, 2017

Sure.

@bbatsov
Copy link
Member

bbatsov commented Apr 30, 2017

Btw, I've noticed both libraries you've mentioned are tiny, so I'm not opposed that much to depending on one of them. I'm curious about the invisioned workflow for the inline docs, thought - would this a replacement for eldoc or just a command bound to some keystroke? Would we should just prototypes or docstrings and metadata as well? Guess those are the most important things to consider.

@stardiviner
Copy link
Contributor Author

stardiviner commented Apr 30, 2017

Those two libraries are just a library, not functional package which can be used directly. There is an existing package which uses inline-docs.el. https://github.com/stardiviner/eldoc-overlay-mode. It uses as a replacement of eldoc default echo-area display. It can be used for other places too. Just change the way of people viewing their information. Don't need to move eye into bottom echo-area. Just viewing info at inline place.

It can be an automatically way like eldoc-overlay-mode and use a command keystroke for cider-doc-* etc.

@bbatsov
Copy link
Member

bbatsov commented Apr 30, 2017

I guess we can implement some command in terms of inline-docs.el and also mention in the eldoc section of the manual eldoc-overlay-mode.

@stardiviner
Copy link
Contributor Author

That's great, this is my first time my Emacs library been used in large project. Happy coding.
Because I don't know CIDER much, hope someone can pick this up. and create an branch for this? I will try to dive into the cider source code. Thanks.

@bbatsov
Copy link
Member

bbatsov commented May 1, 2017

Everything that needs doing is pretty trivial as all the documentation and eldoc code is in cider-doc.el and cider-eldoc.el and the data simply needs to be presented with the new library. I'll mark this as a long-hanging fruit in case some newcomer is interested in tackling it.

@bbatsov bbatsov added good first issue A simple tasks suitable for first-time contributors and removed good first issue A simple tasks suitable for first-time contributors low hanging fruit labels May 8, 2019
@vemv
Copy link
Member

vemv commented Aug 21, 2023

PRs welcome for whatever support work is necessary for those libraries to be integrated.

CIDER already has a variety of "APIs" that Elisp hackers can leverage to get something working.

@vemv vemv closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue A simple tasks suitable for first-time contributors
Projects
None yet
Development

No branches or pull requests

3 participants