-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cider-test-run-test should name the test it's running #1625
Comments
Makes sense. 👍 |
Just an oversight. I never run individual tests, that's why I didn't notice it. |
I've added a dirty fix. In general the code can use some refactoring as the addition of new functionality (e.g. running loaded/project tests) didn't fit very well the original design of the code. |
@bbatsov What strikes you as in need of refactoring? The loaded/project tests feature didn't really change the overall code structure. |
It seems to me that the case of running just a single test doesn't fit very well the general structure of the code. I also dislike a bit passing some keyword instead of the namespace when running |
Fair enough. In actuality, there isn't a single test function; it has always taken a list of tests. That is a bit at odds with the UI, where "one" or "all" are the most natural actions. That could be better aligned, I agree. The keyword passing seems quite reasonable to me though. Maybe a symbol would be more elisp-y, but I think it makes for understandable code. |
When you hit C-c C-t C-t to run a single test you now get
in the modeline.
This is the same text you get when you do C-c C-t C-n which run all the tests in that ns.
Having the same text for both commands has lead me to believe I hit the wrong key combination more than once.
The text was updated successfully, but these errors were encountered: