Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider-test-run-test should name the test it's running #1625

Closed
expez opened this issue Mar 21, 2016 · 6 comments
Closed

cider-test-run-test should name the test it's running #1625

expez opened this issue Mar 21, 2016 · 6 comments

Comments

@expez
Copy link
Member

expez commented Mar 21, 2016

When you hit C-c C-t C-t to run a single test you now get

Running tests in my-test-ns...

in the modeline.

This is the same text you get when you do C-c C-t C-n which run all the tests in that ns.

Having the same text for both commands has lead me to believe I hit the wrong key combination more than once.

@Malabarba
Copy link
Member

Makes sense. 👍

@bbatsov
Copy link
Member

bbatsov commented Mar 21, 2016

Just an oversight. I never run individual tests, that's why I didn't notice it.

@bbatsov
Copy link
Member

bbatsov commented Mar 21, 2016

I've added a dirty fix. In general the code can use some refactoring as the addition of new functionality (e.g. running loaded/project tests) didn't fit very well the original design of the code.

@jeffvalk
Copy link
Contributor

@bbatsov What strikes you as in need of refactoring? The loaded/project tests feature didn't really change the overall code structure.

@bbatsov
Copy link
Member

bbatsov commented Mar 22, 2016

It seems to me that the case of running just a single test doesn't fit very well the general structure of the code. I also dislike a bit passing some keyword instead of the namespace when running :loaded/:project tests. Nothing major for sure, but I just feel we can do a bit better.

@jeffvalk
Copy link
Contributor

Fair enough. In actuality, there isn't a single test function; it has always taken a list of tests. That is a bit at odds with the UI, where "one" or "all" are the most natural actions. That could be better aligned, I agree.

The keyword passing seems quite reasonable to me though. Maybe a symbol would be more elisp-y, but I think it makes for understandable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants