-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache namespaceinfo in repl buffers #1301
Conversation
👍 awesome! General macro font locking is something I've wanted for a while. Now if you could get local font locking to work 😉 |
I don't quite get this. Most IDEs/editors would not font-lock locals anywhere. And there's also the problem of figuring out what's a local - compliment has some limited local inference, but something general will be pretty hard to do. |
I can think of pretty foolproof ways for the middleware to detect which symbols are locals in each scope. So, not likely to happen. :-) |
Ok, I have added a nice |
Finally had a time to go over the PR and most things look. My only real concern is the code copy-pasted from |
Yeah, I wouldn't want it get outdated, but I'm not sure what could be done about it. =/ |
Well, I guess we can live this for now. Apart from my inline comments here's a few more:
|
You'll also have to rebase this. |
Actually, I'm rewriting this now. |
f3451e6
to
f0a0775
Compare
OK, now I'm much more satisfied with the performance. I think it's a little simpler as well. |
Yeah, looks simpler to me as well. I think you only need to update the |
Removed the save-match-data completely, it's no longer necessary. |
Ditch instrumented defs overlay for the new font-locking. All macros are now font-locked. This is configurable via the cider-font-lock-dynamically variable.
Cache namespaceinfo in repl buffers
OK, let's release this into the wild. :-) |
Must go with clojure-emacs/cider-nrepl#249
I think the macro font-locking is pretty nice and should be default. Functions and variables are debatable. Some people might find them excessive so they might be better turned off by default. But I'd like to hear opinions.