cider-repl-clear-buffer stops working #1252

dagda1 · 2015-08-11T19:40:42Z

My projects.clj looks like this:

{:user {
        :dependencies [[com.cemerick/piggieback "0.2.1"]
                       [org.clojure/tools.nrepl "0.2.10"]]
        :plugins [[cider/cider-nrepl "0.10.0-SNAPSHOT"]]
        }}

I'm pretty new to clojure and cider but when I have the code in one window and cider-repl running in the other, it is nice to be able to clear the repl buffer with C-c M-o but C-c M-o stops working after I have executed it once and the buffer has been cleared.

If I select cider-repl-clear-buffer from M-x I can see the error message:

Wrong type argument: integer-or-marker-p nil

The following stack trace in the *Messages* buffer

Loading /Users/paulcowan/projects/scratch/src/scratch/core.clj...
=> nil
Loading /Users/paulcowan/projects/scratch/src/scratch/core.clj...
=> nil
Quit
call-interactively: Wrong type argument: integer-or-marker-p, nil
user-error: Minibuffer window is not active
call-interactively: Wrong type argument: integer-or-marker-p, nil
Auto-saving...done
call-interactively: Wrong type argument: integer-or-marker-p, nilInvalid face attribute :foreground nil
Invalid face attribute :foreground nil [117 times]

So all I do is

cider-jack-in
Write some code and C-c C-k to execute it.
C-c M-o and the buffer clears
Write some code and C-c C-k to execute it.
hit C-c M-o again and cider-repl-clear-buffer no longer works.

If nobody else is experiencing this error, I wonder if my workflow of using C-c C-k is normal?

The text was updated successfully, but these errors were encountered:

Malabarba · 2015-08-11T21:36:54Z

Do M-x toggle-debug-on-error, and then reproduce this error.
You'll get a proper backtrace which you can paste here to give us more information.

dagda1 · 2015-08-12T04:20:56Z

Here is the backtrace:

Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
cider-repl-clear-buffer()
call-interactively(cider-repl-clear-buffer record nil)
command-execute(cider-repl-clear-buffer record)
execute-extended-command(nil "cider-repl-clear-buffer")
smex-read-and-run(("toggle-debug-on-error" "cider-repl-clear-buffer" "cider-jack-in" "list-packages" "magit-status" "ag-project" "enable-paredit-mode" "paredit-mode" "blink-cursor-mode" "global-company-mode" "ag-kill-buffers" "disable-paredit-mode" "kill-other-buffers" "load-file" "kill-some-buffers" "cider-quit" "package-install" "auto-save-mode" "eval-buffer" "cider-restart" "cider-version" "visit-tags-table" "magit-process-kill" "sdb" "ag-mode" "find-library" "minitest-mode" "revert-buffer" "ag/kill-process" "cider-interrupt" "elm-indent-mode" "erc-notify-mode" "ag-project-dired" "cider-repl-kill-input" "package-list-packages" "projectile-invalidate-cache" "cider-repl-toggle-pretty-printing" "org-table-toggle-formula-debugger" "cider-clear-compilation-highlights" "ag" "cd" "5x5" "arp" "dbx" "dig" "erc" "ert" "eww" "ftp" "gdb" ...))
smex()
call-interactively(smex nil nil)
command-execute(smex)

bbatsov · 2015-08-12T04:48:00Z

If nobody else is experiencing this error, I wonder if my workflow of using C-c C-k is normal?

Yeah, that's OK. Personally, I don't use C-c C-k that often - usually I just re-evaluate the code I've actually changed. What's your cider version info?

dagda1 · 2015-08-12T07:13:13Z

@bbatsov here is my version info:

; CIDER 0.10.0snapshot (package: 20150801.627) (Java 1.7.0_45, Clojure 1.6.0, nREPL 0.2.10)

Do you think it would be possible, if you could describe your workflow in a few words?

I think that would be very beneficial to me.

Malabarba · 2015-08-12T08:13:15Z

My workflow is to just reload code I just changed by hitting C-M-x on it. But there's nothing wrong with using C-c C-k, a lot of people do that and I'm sure one of them would have noticed your issue.

It's clear that one of the repl markers is being set to nil for you, even though all of them should always be valid markers.

Do you have anything in cider-repl-clear-buffer-hook?
When you get this problem, which of the following vars is nil for you: cider-repl-prompt-start-mark, cider-repl-output-start, cider-repl-output-end, or cider-repl-input-start-mark?

dagda1 · 2015-08-12T09:11:57Z

Is cider-repl-clear-buffer-hook a command? I don't have it available through M-x.

Malabarba · 2015-08-12T09:23:52Z

No, it's a variable. Try to see it with C-h v. If you don't get anything, that's normal.

dagda1 · 2015-08-12T10:38:58Z

So when I run c-h v for cider-repl-prompt-start-mark I get:

cider-repl-prompt-start-mark is a variable defined in `cider-repl.el'.
Its value is nil

  Automatically becomes buffer-local when set.

for cider-repl-output-start

cider-repl-output-start is a variable defined in `cider-repl.el'.
Its value is nil

  Automatically becomes buffer-local when set.

The same is true for cider-repl-output-end and cider-repl-input-start-mark.

Malabarba · 2015-08-12T11:21:08Z

Did you do that inside the repl buffer?

dagda1 · 2015-08-12T11:33:10Z

Ah right, my bad,

Here are the variables in the buffer.

cider-repl-prompt-start-mark outputs

cider-repl-prompt-start-mark is a variable defined in `cider-repl.el'.
Its value is #<marker at 93 in *cider-repl scratch*>
Local in buffer *cider-repl scratch*; global value is nil

  Automatically becomes buffer-local when set.

cider-repl-output-start outputs:

cider-repl-output-start is a variable defined in `cider-repl.el'.
Its value is #<marker at 92 in *cider-repl scratch*>
Local in buffer *cider-repl scratch*; global value is nil

  Automatically becomes buffer-local when set.

cider-repl-output-end outputs

cider-repl-output-end is a variable defined in `cider-repl.el'.
Its value is #<marker at 92 in *cider-repl scratch*>
Local in buffer *cider-repl scratch*; global value is nil

cider-repl-input-start-mark outputs

cider-repl-input-start-mark is a variable defined in `cider-repl.el'.
Its value is #<marker at 99 in *cider-repl scratch*>
Local in buffer *cider-repl scratch*; global value is nil

  Automatically becomes buffer-local when set.

cider-repl-clear-buffer-hook gives no match.

Malabarba · 2015-08-12T11:57:40Z

Ok, one more question. :) Is that after reproducing the problem?

dagda1 · 2015-08-12T12:05:38Z

I've captured the variables again after the problem:

cider-repl-prompt-start-mark outputs

cider-repl-prompt-start-mark is a variable defined in `cider-repl.el'.
Its value is #<marker at 1 in *cider-repl scratch*>
Local in buffer *cider-repl scratch*; global value is nil

  Automatically becomes buffer-local when set.

cider-repl-output-start outputs:

cider-repl-output-start is a variable defined in `cider-repl.el'.
Its value is #<marker at 1 in *cider-repl scratch*>
Local in buffer *cider-repl scratch*; global value is nil

  Automatically becomes buffer-local when set.

cider-repl-output-end outputs

cider-repl-output-end is a variable defined in `cider-repl.el'.
Its value is #<marker at 1 in *cider-repl scratch*>
Local in buffer *cider-repl scratch*; global value is nil

cider-repl-input-start-mark outputs

cider-repl-input-start-mark is a variable defined in `cider-repl.el'.
Its value is #<marker at 255 in *cider-repl scratch*>
Local in buffer *cider-repl scratch*; global value is nil

cider-repl-clear-buffer-hook gives no match.

Malabarba · 2015-08-12T12:28:01Z

Alright. Then I think it's safe to say that I am clueless. :)

dagda1 · 2015-08-12T16:53:07Z

Same thing happens even if I use C-M x.

cider-repl-clear-buffer is not a happy bunny for me anyway after the first execution irrespective of what proceeds it.

expez · 2015-08-13T07:14:38Z

@dagda1 you might have to dig into edebug to debug this function yourself. Learning edebug takes around 5 minutes--it's incredibly easy to use--and it's well worth the trouble imo.

Malabarba · 2015-08-13T08:37:14Z

Edebug: http://endlessparentheses.com/debugging-emacs-lisp-part-1-earn-your-independence.html

scottdw · 2015-08-13T15:41:20Z

Are you running cider-repl-clear-buffer from the file buffer or the repl buffer, @dagda1?

scottdw · 2015-08-13T15:56:47Z

Nevermind, that doesn't seem to affect it. It appears that the first time some code is evaluated the output appears before repl prompt and after C-c M-o it appears after the prompt. Pressing Enter to get back the repl prompt makes cider-repl-clear-buffer work again.

dagda1 · 2015-08-13T16:11:41Z

@scottdw absolutely, that works. If I press enter after each evaluation then the repl can be cleared each time.

dagda1 · 2015-08-13T16:13:07Z

I'm curious as to why experienced users have not encountered this. Do they not use the cider-repl-clear-buffer command?

expez · 2015-08-14T13:43:11Z

I'm curious as to why experienced users have not encountered this. Do they not use the cider-repl-clear-buffer command?

I only use it when the output in the buffer is causing trouble. e.g. when it contains unbalanced parens etc and smartparens is screaming at me.

Additionally, it's super unusual to have forms causing side-effects and emitting output to the repl as toplevel forms that get evaluated when calling C-c C-k.

Steps to reproduce

Open a clj buffer and insert (println (+ 1 1))
C-c C-k
C-c M-o
C-c C-k

After running cider-repl-clear-buffer and then loading a file creating output (e.g. because it contains println statements) the output would appear in the wrong place, causing the prompt to disappear. The problem was in the function responsible for putting POINT in the right place before emitting evaluation results into the repl buffer. When the prompt was the first line in the buffer, cider-repl--end-of-line-before-input-start didn't move point at all. There's now a special case in place to handle this situation. I initially considered solving this problem by making sure that the prompt wasn't the first line in the buffer, after noticing that he banner was being deleted by cider-repl-clear-buffer. While I think the banner should be preserved by this function, the banner itself is optional so this was a non-solution.

[Fix #1252] Fix breakage in cider-repl-clear-buffer

expez added the bug label Aug 14, 2015

expez closed this as completed in 2cccb45 Aug 17, 2015

bbatsov added a commit that referenced this issue Aug 17, 2015

Merge pull request #1261 from clojure-emacs/clear-buffer-stops-working

2dccfd6

[Fix #1252] Fix breakage in cider-repl-clear-buffer

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cider-repl-clear-buffer stops working #1252

cider-repl-clear-buffer stops working #1252

dagda1 commented Aug 11, 2015

Malabarba commented Aug 11, 2015

dagda1 commented Aug 12, 2015

bbatsov commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

expez commented Aug 13, 2015

Malabarba commented Aug 13, 2015

scottdw commented Aug 13, 2015

scottdw commented Aug 13, 2015

dagda1 commented Aug 13, 2015

dagda1 commented Aug 13, 2015

expez commented Aug 14, 2015

cider-repl-clear-buffer stops working #1252

cider-repl-clear-buffer stops working #1252

Comments

dagda1 commented Aug 11, 2015

Malabarba commented Aug 11, 2015

dagda1 commented Aug 12, 2015

bbatsov commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

Malabarba commented Aug 12, 2015

dagda1 commented Aug 12, 2015

expez commented Aug 13, 2015

Malabarba commented Aug 13, 2015

scottdw commented Aug 13, 2015

scottdw commented Aug 13, 2015

dagda1 commented Aug 13, 2015

dagda1 commented Aug 13, 2015

expez commented Aug 14, 2015