You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The filter buttons are always underlined, even when toggled off
All frames are underlined
e.g. with font-lock-mode enabled/disabled:
It seems the default button face is always being used as button only cares about the face property and not the font-lock-face property. If I change cider-stacktrace.el to use face when rendering the buttons and frames, all is better with both font-lock-mode enabled and disabled:
Would you accept a PR to this effect? The change to font-lock-face was in 401e819, to fix #749 - but I think in this particular case, things like parenface and rainbow-delimiters don't really apply. Thoughts?
The text was updated successfully, but these errors were encountered:
cichli
added a commit
to cichli/cider
that referenced
this issue
Mar 20, 2015
e.g. with
font-lock-mode
enabled/disabled:It seems the default
button
face is always being used asbutton
only cares about theface
property and not thefont-lock-face
property. If I changecider-stacktrace.el
to useface
when rendering the buttons and frames, all is better with bothfont-lock-mode
enabled and disabled:Would you accept a PR to this effect? The change to
font-lock-face
was in 401e819, to fix #749 - but I think in this particular case, things likeparenface
andrainbow-delimiters
don't really apply. Thoughts?The text was updated successfully, but these errors were encountered: