Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous underlining in error buffer #1033

Closed
cichli opened this issue Mar 20, 2015 · 0 comments · Fixed by #1034
Closed

Erroneous underlining in error buffer #1033

cichli opened this issue Mar 20, 2015 · 0 comments · Fixed by #1034

Comments

@cichli
Copy link
Member

cichli commented Mar 20, 2015

  • The filter buttons are always underlined, even when toggled off
  • All frames are underlined

e.g. with font-lock-mode enabled/disabled:

screenshot 2015-03-20 12 28 01
screenshot 2015-03-20 12 29 03

It seems the default button face is always being used as button only cares about the face property and not the font-lock-face property. If I change cider-stacktrace.el to use face when rendering the buttons and frames, all is better with both font-lock-mode enabled and disabled:

screenshot 2015-03-20 12 36 54
screenshot 2015-03-20 12 37 06

Would you accept a PR to this effect? The change to font-lock-face was in 401e819, to fix #749 - but I think in this particular case, things like parenface and rainbow-delimiters don't really apply. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant