Skip to content

Commit

Permalink
Added cider-doc-auto-select-buffer custom variable
Browse files Browse the repository at this point in the history
Added cider-doc-auto-select-buffer custom variable to control if the documentation viewer popup will be autoselected after opening.
  • Loading branch information
nahuel committed May 21, 2017
1 parent ec2a10b commit aceab73
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* [#1726](https://github.com/clojure-emacs/cider/issues/1726): Order keys in printed nrepl message objects.
* [#1832](https://github.com/clojure-emacs/cider/issues/1832): Add new customization variable `cider-eldoc-display-context-dependent-info` to control showing eldoc info for datomic query input parameters.
* Make it possible to disable auto-evaluation of changed ns forms via the defcustom `cider-auto-track-ns-form-changes`.
* [#1995](https://github.com/clojure-emacs/cider/pull/1995): Add new customization variable `cider-doc-auto-select-buffer` to control cider-doc popup buffer auto selection

This comment has been minimized.

Copy link
@bbatsov

bbatsov May 22, 2017

Member

This sentence should end with a ..


### Changes

Expand Down
6 changes: 5 additions & 1 deletion cider-doc.el
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@
:group 'cider-docview-mode
:package-version '(cider . "0.7.0"))

(defcustom cider-doc-auto-select-buffer t
"Autoselect the documentation viewer after popup."

This comment has been minimized.

Copy link
@bbatsov

bbatsov May 22, 2017

Member

"Controls whether to auto-select the doc popup buffer."

:type 'boolean
:group 'cider-doc)

This comment has been minimized.

Copy link
@bbatsov

bbatsov May 22, 2017

Member

Don't forget the :package-version here. The defcustom I referred to was old (before we started maintaining them).



;; Faces
Expand Down Expand Up @@ -263,7 +267,7 @@ opposite of what that option dictates."
(defun cider-doc-lookup (symbol)
"Look up documentation for SYMBOL."
(if-let ((buffer (cider-create-doc-buffer symbol)))
(cider-popup-buffer-display buffer t)
(cider-popup-buffer-display buffer cider-doc-auto-select-buffer)
(user-error "Symbol %s not resolved" symbol)))

(defun cider-doc (&optional arg)
Expand Down

0 comments on commit aceab73

Please sign in to comment.