Change format of forms-str and arglists-str #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes clojure-emacs#411. forms-str now looks like: "(.instanceMember instance args*)\n(.instanceMember Classname args*)" arglists-str now looks like: "[x]\n[x y]\n[x y z]" Changes include: - No extraneous whitespace - Newlines Previously, the two had inconsistent formats. arglists-str looked like: "([x] [x y] [x y z])" forms-str looked like: " [(.instanceMember instance args*)\n (.instanceMember Classname args*)]"
7 tasks
xiongtx
added a commit
to xiongtx/cider
that referenced
this pull request
Jun 18, 2017
Depends on clojure-emacs/cider-nrepl#412. Using the new forms-str and arglists-str formats simplifies code for `cider-docview-render-info`.
|
👍 |
bbatsov
pushed a commit
to clojure-emacs/cider
that referenced
this pull request
Jun 18, 2017
Depends on clojure-emacs/cider-nrepl#412. Using the new forms-str and arglists-str formats simplifies code for `cider-docview-render-info`.
It's not a big deal, but it might be even better to return just a vector of all signatures and leave it to the client to join those however they see fit. |
|
Vector as in Clojure vector? Doesn't everything that's moved b/t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411.
forms-str now looks like:
arglists-str now looks like:
Changes include:
Previously, the two had inconsistent formats.
arglists-str looked like:
forms-str looked like:
Before submitting a PR make sure the following things have been done:
Thanks!