[Fix #266] Only forward server out to subscribed clients #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malabarba
added a commit
to clojure-emacs/cider
that referenced
this pull request
Oct 17, 2015
Related to clojure-emacs/cider-nrepl#266. Goes with clojure-emacs/cider-nrepl#267.
|
Seems you forgot to update the tests. The changes themselves look reasonable to me. |
|
Tests hopefully fixed now. |
Connected sessions must send a message with an "out-subscribe" op in order to have server messages forwarded to them. The forwarded outs are then sent as replies to this message (so it must be able to handle out).
|
Only coveralls is failing. I've added a test about for the only new function, but I can't figure out other tests anymore than I could before. :-P |
bbatsov
added a commit
that referenced
this pull request
Oct 19, 2015
[Fix #266] Only forward server out to subscribed clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected sessions must send a message with an "out-subscribe" op in
order to have server messages forwarded to them. The forwarded outs are then
sent as replies to this message (so it must be able to handle out).