Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Using the
openssl
crate significantly increases the build times on Windows. Switching torustls
improves it:Expected complexity level and risk
*How complicated do you think these changes are? Grade on a scale from 1 to 5,
3
It looks correct to me the generation and reading of keys. However, even if trivial, changing libraries that do crypto requires careful eyes.
Testing
openssl
.*quickstart
and re-read the keys