feat(1329): System table for system variables #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/feat/sys-var-table
branch
from
7da35b4
to
563a3d3
Compare
joshua-spacetime
force-pushed
the
joshua/feat/sys-var-table
branch
from
563a3d3
to
35a2075
Compare
|
I think you need to mark this as potentially breaking because the table |
mamcx
reviewed
Jun 6, 2024
|
|
||
| /// The type of a system variable in `st_var` | ||
| #[repr(u8)] | ||
| pub enum StVarType { |
There was a problem hiding this comment.
Why do we need another type for this? I think just matching on AlgebraicType if wanna restrict to primitive types is enough
There was a problem hiding this comment.
Can a column be typed as AlgebraicValue? I was under the assumption it needed a concrete type. In this case, AlgebraicType::Sum(...).
There was a problem hiding this comment.
We could conceivably impl SpacetimeType for AlgebraicValue by having an AlgebraicType which describes AlgebraicValue.
joshua-spacetime
commented
Jun 6, 2024
| ) -> Result<(), DBError> { | ||
| if auth.caller != auth.owner { | ||
| if let Some(limit) = config.row_limit { | ||
| if let Some(limit) = StVarTable::row_limit(ctx, db, tx)? { |
There was a problem hiding this comment.
We use the row_limit in st_var when estimating cardinality.
Closes #1329. Used to persist global parameters for slow query logging and cardinality limits.
joshua-spacetime
force-pushed
the
joshua/feat/sys-var-table
branch
from
44c7daf
to
6e89743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1329.
Used to persist global parameters for slow query logging and cardinality limits.
Expected complexity level and risk
2
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!