Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver-type #642

Closed
dgr opened this issue Aug 22, 2024 · 0 comments · Fixed by #643
Closed

Add driver-type #642

dgr opened this issue Aug 22, 2024 · 0 comments · Fixed by #643

Comments

@dgr
Copy link
Contributor

dgr commented Aug 22, 2024

Problem/Opportunity
Currently, Etaoin has no public way to determine the type of driver that is running. There is a driver? API, but this tests whether the driver is of a particular type (e.g., answers the question, "Is this driver :chrome?"). Consequently, various pieces of Etaoin code have been using dispatch-driver, but this is not a public API and has an odd name that suggests its internal function but is not suited for external users.

Proposed Solution
Create a public function named driver-type that returns one of :chrome, :firefox, :safari, or :edge. This public function merely calls dispatch-driver under the hood.

Alternative Solutions
Muddle through with the current status quo.

Additional context
None.

Action
I'll submit a PR.

@dgr dgr mentioned this issue Aug 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant