-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quit timeout #599
Comments
I vaguely remember that I might have some work-in-progress that could address this... I'll take a peek sometime soon. |
Oh hold on, sorry, I think I misread your issue entirely. Here's me doing what you did but with clojure cli (from a new empty dir) $ clojure -Sdeps '{:deps {etaoin/etaoin {:mvn/version "1.0.40"}}}'
Clojure 1.11.3
user=> (require '[etaoin.api :as e])
nil
user=> (def driver (e/firefox))
#'user/driver
user=> (e/quit driver)
{:args ("geckodriver" "--port" 38433), :capabilities {:loggingPrefs {:browser "ALL"}}, :process {:proc #object[java.lang.ProcessImpl 0x13cc3984 "Process[pid=160086, exitValue=143]"], :exit nil, :in #object[java.lang.ProcessImpl$ProcessPipeOutputStream 0x55465bfc "java.lang.ProcessImpl$ProcessPipeOutputStream@55465bfc"], :out #object[java.lang.ProcessBuilder$NullInputStream 0x5625ba2 "java.lang.ProcessBuilder$NullInputStream@5625ba2"], :err #object[java.lang.ProcessBuilder$NullInputStream 0x5625ba2 "java.lang.ProcessBuilder$NullInputStream@5625ba2"], :prev nil, :cmd ["geckodriver" "--port" "38433"]}, :locator "xpath", :type :firefox, :port 38433, :host "127.0.0.1", :url "http://127.0.0.1:38433"}
user=> I'm not seeing the timeout issue here, can you double-check versions of things you are running? |
Just for comparison, here's what I am running:
|
Thanks for the quick replies. Been stuck without Internet most of today, right after I filed the issue. Yea, |
Yeah, I was out to lunch thinking this was related to #517. 🙂 Looking forward to learning more about your timeout issue. |
OK, some more data. Firstly, using Clojure CLI had no effect on the outcome. Same result.
And
Finally, I also tried it from Clojure CLI with Safari. This worked. So, there's something at issue with Firefox/Geckodriver. Perhaps it's not an Etaoin bug at all, but a bug there?
I'm not sure what to do next. Let me know if you need more info and I'll try to get it for you. |
Hmm... here's a try from an M1 MacBook: First tools-versions:
And now let's try sending output to the console via
If you do the above, do you see anything very different? Also you might check your geckodriver architecture via: ~ (file $(which geckodriver))
/opt/homebrew/bin/geckodriver: Mach-O 64-bit executable arm64 Maybe there is something wrong with your geckodriver, I suppose you could try to reinstall it: ~ brew reinstall geckodriver |
Hm... things are getting odd. I tried doing exactly what you did above, and this time it worked.
No hang or timeout exception. Weird. For completeness:
So, I guess it fixed itself, maybe? I did have to reboot my machine this morning. The only thing I can think of is that something in MacOS bork'd Firefox (?!). Maybe the reboot unbork'd it? I ran Given that it works, let's close this. I'll reopen it if it happens again and try to gather more data. Sorry for the trouble. |
No trouble at all! Thanks for reaching out, your issue just might help some other person who happens to hit the same symptom. Best guess at resolution: reboot your mac! |
Version
1.0.40
Platform
Operating System: MacOS 14.5 (Sonoma)
Clojure version: 1.11.1
Babashka version: 1.3.191
JDK vendor and version: Azul Zulu 17.0.11,17.50.19
Browser vendor: firefox
Browser version: 125.0.1
WebDriver version: Geckodriver 0.34.0, installed via brew
Symptom
Invoking etaoin/quit or etaoin/delete-session results in an exception being thrown indicating a timeout. Note that the browser window is destroyed prior to the timeout but the firefox process remains running.
Reproduction
This is the simplest reproduction.
Actual behavior
Timeout occurs.
Expected behavior
quit/delete-session should quit cleanly without a timeout.
Diagnosis
No.
Action
Unsure. I'll try to gather more info.
The text was updated successfully, but these errors were encountered: